linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dwmw2@infradead.org (David Woodhouse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] iommu/intel: announce supported page sizes
Date: Tue, 13 Sep 2011 22:32:59 +0100	[thread overview]
Message-ID: <1315949582.2687.204.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1315942288-17297-5-git-send-email-ohad@wizery.com>

On Tue, 2011-09-13 at 22:31 +0300, Ohad Ben-Cohen wrote:
> + * Traditionally the IOMMU core just handed us the mappings directly,
> + * after making sure the size is an order of a 4KB page and that the
> + * mapping has natural alignment.
> + *
> + * To retain this behavior, we currently advertise that we support
> + * all page sizes that are an order of 4KB. 

This is wrong. We do not support 4000-byte pages. We only support
4096-byte pages. 4KiB, not 4kB.

Please fix.

-- 
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110913/9925b4a6/attachment.bin>

  reply	other threads:[~2011-09-13 21:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13 19:31 [PATCH v2 1/6] iommu/core: split mapping to page sizes as supported by the hardware Ohad Ben-Cohen
2011-09-13 19:31 ` [PATCH v2 2/6] iommu/omap: announce supported page sizes Ohad Ben-Cohen
2011-09-13 19:31 ` [PATCH v2 3/6] iommu/msm: " Ohad Ben-Cohen
2011-09-13 19:31 ` [PATCH v2 4/6] iommu/amd: " Ohad Ben-Cohen
2011-09-13 19:31 ` [PATCH v2 5/6] iommu/intel: " Ohad Ben-Cohen
2011-09-13 21:32   ` David Woodhouse [this message]
2011-09-14  5:11     ` Ohad Ben-Cohen
2011-09-13 19:31 ` [PATCH v2 6/6] iommu/core: remove the temporary register_iommu_pgsize API Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315949582.2687.204.camel@shinybook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).