* [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin
@ 2011-09-17 14:15 Axel Lin
2011-09-22 10:30 ` Igor Grinberg
0 siblings, 1 reply; 6+ messages in thread
From: Axel Lin @ 2011-09-17 14:15 UTC (permalink / raw)
To: linux-arm-kernel
Fix below build warning and properly set bt_reset pin.
CC arch/arm/mach-pxa/cm-x300.o
arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
arch/arm/mach-pxa/cm-x300.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c
index 0f00e01..0e18eb9 100644
--- a/arch/arm/mach-pxa/cm-x300.c
+++ b/arch/arm/mach-pxa/cm-x300.c
@@ -776,7 +776,6 @@ static struct gpio cm_x300_wi2wi_gpios[] __initdata = {
static void __init cm_x300_init_wi2wi(void)
{
- int bt_reset, wlan_en;
int err;
if (system_rev < 130) {
@@ -792,12 +791,11 @@ static void __init cm_x300_init_wi2wi(void)
}
udelay(10);
- gpio_set_value(bt_reset, 0);
+ gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 0);
udelay(10);
- gpio_set_value(bt_reset, 1);
+ gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 1);
- gpio_free(wlan_en);
- gpio_free(bt_reset);
+ gpio_free_array(ARRAY_AND_SIZE(cm_x300_wi2wi_gpios));
}
/* MFP */
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin
2011-09-17 14:15 [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin Axel Lin
@ 2011-09-22 10:30 ` Igor Grinberg
2011-09-29 7:57 ` Axel Lin
0 siblings, 1 reply; 6+ messages in thread
From: Igor Grinberg @ 2011-09-22 10:30 UTC (permalink / raw)
To: linux-arm-kernel
Hi Axel,
On 09/17/11 17:15, Axel Lin wrote:
> Fix below build warning and properly set bt_reset pin.
>
> CC arch/arm/mach-pxa/cm-x300.o
> arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
> arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
> arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function
What a shame...
My patch 5a009df1f200efa49658b0e9c7ad056d59fbefe4
(ARM: pxa/cm-x300: GPIO cleanup) was f*cked up, sorry...
I should have not send it in a rush and I admit,
I had no possibility to test it. Sorry again...
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Thanks for spotting this.
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Also, this patch fixes a real regression since
5a009df1f200efa49658b0e9c7ad056d59fbefe4 (ARM: pxa/cm-x300: GPIO cleanup)
- Wifi and Bluetooth do not work without it, so please:
Cc: <stable@kernel.org> [3.0.x]
> ---
> arch/arm/mach-pxa/cm-x300.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c
> index 0f00e01..0e18eb9 100644
> --- a/arch/arm/mach-pxa/cm-x300.c
> +++ b/arch/arm/mach-pxa/cm-x300.c
> @@ -776,7 +776,6 @@ static struct gpio cm_x300_wi2wi_gpios[] __initdata = {
>
> static void __init cm_x300_init_wi2wi(void)
> {
> - int bt_reset, wlan_en;
> int err;
>
> if (system_rev < 130) {
> @@ -792,12 +791,11 @@ static void __init cm_x300_init_wi2wi(void)
> }
>
> udelay(10);
> - gpio_set_value(bt_reset, 0);
> + gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 0);
> udelay(10);
> - gpio_set_value(bt_reset, 1);
> + gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 1);
>
> - gpio_free(wlan_en);
> - gpio_free(bt_reset);
> + gpio_free_array(ARRAY_AND_SIZE(cm_x300_wi2wi_gpios));
> }
>
> /* MFP */
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin
2011-09-22 10:30 ` Igor Grinberg
@ 2011-09-29 7:57 ` Axel Lin
2011-10-17 15:45 ` Igor Grinberg
0 siblings, 1 reply; 6+ messages in thread
From: Axel Lin @ 2011-09-29 7:57 UTC (permalink / raw)
To: linux-arm-kernel
2011/9/22 Igor Grinberg <grinberg@compulab.co.il>:
> Hi Axel,
>
> On 09/17/11 17:15, Axel Lin wrote:
>> Fix below build warning and properly set bt_reset pin.
>>
>> ? CC ? ? ?arch/arm/mach-pxa/cm-x300.o
>> arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
>> arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
>> arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>
> Also, this patch fixes a real regression since
> 5a009df1f200efa49658b0e9c7ad056d59fbefe4 (ARM: pxa/cm-x300: GPIO cleanup)
> - Wifi and Bluetooth do not work without it, so please:
>
> Cc: <stable@kernel.org> [3.0.x]
>
Hi, Eric,
Just to pin the status of this patch. I think it should go for 3.1.
Thanks,
Axel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin
2011-09-29 7:57 ` Axel Lin
@ 2011-10-17 15:45 ` Igor Grinberg
2011-10-25 14:30 ` Igor Grinberg
0 siblings, 1 reply; 6+ messages in thread
From: Igor Grinberg @ 2011-10-17 15:45 UTC (permalink / raw)
To: linux-arm-kernel
ping
On 09/29/11 10:57, Axel Lin wrote:
> 2011/9/22 Igor Grinberg <grinberg@compulab.co.il>:
>> Hi Axel,
>>
>> On 09/17/11 17:15, Axel Lin wrote:
>>> Fix below build warning and properly set bt_reset pin.
>>>
>>> CC arch/arm/mach-pxa/cm-x300.o
>>> arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
>>> arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
>>> arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function
>>
>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>>
>> Also, this patch fixes a real regression since
>> 5a009df1f200efa49658b0e9c7ad056d59fbefe4 (ARM: pxa/cm-x300: GPIO cleanup)
>> - Wifi and Bluetooth do not work without it, so please:
>>
>> Cc: <stable@kernel.org> [3.0.x]
>>
> Hi, Eric,
> Just to pin the status of this patch. I think it should go for 3.1.
> Thanks,
> Axel
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin
2011-10-17 15:45 ` Igor Grinberg
@ 2011-10-25 14:30 ` Igor Grinberg
2011-10-25 14:37 ` Eric Miao
0 siblings, 1 reply; 6+ messages in thread
From: Igor Grinberg @ 2011-10-25 14:30 UTC (permalink / raw)
To: linux-arm-kernel
ping x2
On 10/17/2011 05:45 PM, Igor Grinberg wrote:
> ping
>
> On 09/29/11 10:57, Axel Lin wrote:
>> 2011/9/22 Igor Grinberg <grinberg@compulab.co.il>:
>>> Hi Axel,
>>>
>>> On 09/17/11 17:15, Axel Lin wrote:
>>>> Fix below build warning and properly set bt_reset pin.
>>>>
>>>> CC arch/arm/mach-pxa/cm-x300.o
>>>> arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
>>>> arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
>>>> arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function
>>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>>>
>>> Also, this patch fixes a real regression since
>>> 5a009df1f200efa49658b0e9c7ad056d59fbefe4 (ARM: pxa/cm-x300: GPIO cleanup)
>>> - Wifi and Bluetooth do not work without it, so please:
>>>
>>> Cc: <stable@kernel.org> [3.0.x]
>>>
>> Hi, Eric,
>> Just to pin the status of this patch. I think it should go for 3.1.
>> Thanks,
>> Axel
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin
2011-10-25 14:30 ` Igor Grinberg
@ 2011-10-25 14:37 ` Eric Miao
0 siblings, 0 replies; 6+ messages in thread
From: Eric Miao @ 2011-10-25 14:37 UTC (permalink / raw)
To: linux-arm-kernel
sorry x 3
Missed this, queued now.
On Tue, Oct 25, 2011 at 10:30 PM, Igor Grinberg <grinberg@compulab.co.il> wrote:
> ping x2
>
> On 10/17/2011 05:45 PM, Igor Grinberg wrote:
>> ping
>>
>> On 09/29/11 10:57, Axel Lin wrote:
>>> 2011/9/22 Igor Grinberg <grinberg@compulab.co.il>:
>>>> Hi Axel,
>>>>
>>>> On 09/17/11 17:15, Axel Lin wrote:
>>>>> Fix below build warning and properly set bt_reset pin.
>>>>>
>>>>> ? CC ? ? ?arch/arm/mach-pxa/cm-x300.o
>>>>> arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
>>>>> arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
>>>>> arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function
>>>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>>>>
>>>> Also, this patch fixes a real regression since
>>>> 5a009df1f200efa49658b0e9c7ad056d59fbefe4 (ARM: pxa/cm-x300: GPIO cleanup)
>>>> - Wifi and Bluetooth do not work without it, so please:
>>>>
>>>> Cc: <stable@kernel.org> [3.0.x]
>>>>
>>> Hi, Eric,
>>> Just to pin the status of this patch. I think it should go for 3.1.
>>> Thanks,
>>> Axel
>>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-25 14:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-17 14:15 [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin Axel Lin
2011-09-22 10:30 ` Igor Grinberg
2011-09-29 7:57 ` Axel Lin
2011-10-17 15:45 ` Igor Grinberg
2011-10-25 14:30 ` Igor Grinberg
2011-10-25 14:37 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).