From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Wed, 21 Sep 2011 13:30:43 +0200 Subject: [PATCH 09/11 v2] ARM: at92/ohci: use gpio_is_valid to check the gpio In-Reply-To: <20110921112830.GP24966@game.jcrosoft.org> References: <20110921112830.GP24966@game.jcrosoft.org> Message-ID: <1316604645-22599-9-git-send-email-plagnioj@jcrosoft.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Acked-by: Nicolas Ferre --- V2 update commit log Best Regards, J. drivers/usb/host/ohci-at91.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index e08cb10..70701f4 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -276,7 +276,7 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev) * active-low power switches. */ for (i = 0; i < ARRAY_SIZE(pdata->vbus_pin); i++) { - if (pdata->vbus_pin[i] <= 0) + if (!gpio_is_valid(pdata->vbus_pin[i])) continue; gpio_request(pdata->vbus_pin[i], "ohci_vbus"); gpio_direction_output(pdata->vbus_pin[i], 0); @@ -294,7 +294,7 @@ static int ohci_hcd_at91_drv_remove(struct platform_device *pdev) if (pdata) { for (i = 0; i < ARRAY_SIZE(pdata->vbus_pin); i++) { - if (pdata->vbus_pin[i] <= 0) + if (!gpio_is_valid(pdata->vbus_pin[i])) continue; gpio_direction_output(pdata->vbus_pin[i], 1); gpio_free(pdata->vbus_pin[i]); -- 1.7.6.3