From: mhban@samsung.com (mhban)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: futex: fix clobbering oldval
Date: Thu, 22 Sep 2011 11:53:35 +0900 [thread overview]
Message-ID: <1316660015.6872.1.camel@puffmine-laptop> (raw)
This patch fixes clobbering oldval bug. oldval should be preserved for next
compare operation.
Change-Id: I2a63bc1bdb8de330eb9e1ac02d7da1f77e6e8c3c
Signed-off-by: Minho Ban <mhban@samsung.com>
---
arch/arm/include/asm/futex.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/futex.h b/arch/arm/include/asm/futex.h
index d2d733c..b0f2e8e 100644
--- a/arch/arm/include/asm/futex.h
+++ b/arch/arm/include/asm/futex.h
@@ -30,14 +30,14 @@
__asm__ __volatile__( \
"1: ldrex %1, [%2]\n" \
" " insn "\n" \
- "2: strex %1, %0, [%2]\n" \
- " teq %1, #0\n" \
+ "2: strex r5, %0, [%2]\n" \
+ " teq r5, #0\n" \
" bne 1b\n" \
" mov %0, #0\n" \
__futex_atomic_ex_table("%4") \
: "=&r" (ret), "=&r" (oldval) \
: "r" (uaddr), "r" (oparg), "Ir" (-EFAULT) \
- : "cc", "memory")
+ : "r5", "cc", "memory")
static inline int
futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
--
1.7.0.4
next reply other threads:[~2011-09-22 2:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 2:53 mhban [this message]
2011-09-22 17:26 ` [PATCH] ARM: futex: fix clobbering oldval Will Deacon
2011-09-23 0:18 ` mhban
2011-09-23 8:43 ` Will Deacon
2011-12-06 18:58 ` Jon Masters
2011-12-06 19:11 ` Will Deacon
2011-12-06 19:38 ` Jon Masters
2011-12-06 21:14 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316660015.6872.1.camel@puffmine-laptop \
--to=mhban@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox