linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: abhilash.kv@ti.com (Abhilash K V)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] OMAP2+: voltage: add check for missing PMIC info in vp init
Date: Thu, 22 Sep 2011 18:56:33 +0530	[thread overview]
Message-ID: <1316697993-696-4-git-send-email-abhilash.kv@ti.com> (raw)
In-Reply-To: <1316697993-696-3-git-send-email-abhilash.kv@ti.com>

If PMIC info is not available in omap_vp_init(), abort.

Signed-off-by: Abhilash K V <abhilash.kv@ti.com>
---
 arch/arm/mach-omap2/vp.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/vp.c b/arch/arm/mach-omap2/vp.c
index 66bd700..2c99837 100644
--- a/arch/arm/mach-omap2/vp.c
+++ b/arch/arm/mach-omap2/vp.c
@@ -41,6 +41,13 @@ void __init omap_vp_init(struct voltagedomain *voltdm)
 	u32 val, sys_clk_rate, timeout, waittime;
 	u32 vddmin, vddmax, vstepmin, vstepmax;
 
+	if (!voltdm->pmic || !voltdm->pmic->uv_to_vsel) {
+		pr_err("%s: PMIC info requried to configure vp for"
+			"vdd_%s not populated.Hence cannot initialize vp\n",
+			__func__, voltdm->name);
+		return;
+	}
+
 	if (!voltdm->read || !voltdm->write) {
 		pr_err("%s: No read/write API for accessing vdd_%s regs\n",
 			__func__, voltdm->name);
-- 
1.7.1

  reply	other threads:[~2011-09-22 13:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 13:26 [PATCH v4 0/3] AM3517: Booting up Abhilash K V
2011-09-22 13:26 ` [PATCH v4 1/3] AM35x: Using OMAP3 generic hwmods Abhilash K V
2011-09-22 13:26   ` [PATCH v4 2/3] omap_twl: Prevent SR to enable for am3517/am3505 devices Abhilash K V
2011-09-22 13:26     ` Abhilash K V [this message]
2011-09-22 21:39       ` [PATCH v4 3/3] OMAP2+: voltage: add check for missing PMIC info in vp init Kevin Hilman
2011-09-22 21:35     ` [PATCH v4 2/3] omap_twl: Prevent SR to enable for am3517/am3505 devices Kevin Hilman
2011-09-23 12:51       ` Koyamangalath, Abhilash
2011-09-22 19:10   ` [PATCH v4 1/3] AM35x: Using OMAP3 generic hwmods Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316697993-696-4-git-send-email-abhilash.kv@ti.com \
    --to=abhilash.kv@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).