[PATCH] arm: Add VIRTUALIZATION configuration menu and virtio options

[PATCH] arm: Add VIRTUALIZATION configuration menu and virtio options

[Pawel Moll]

This patch adds menuconfig VIRTUALIZATION to arm Kconfig
and includes virtio Kconfig in it.

Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
 arch/arm/Kconfig |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 3269576..426f330 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2101,4 +2101,20 @@ source "security/Kconfig"
 
 source "crypto/Kconfig"
 
+menuconfig VIRTUALIZATION
+	bool "Virtualization"
+	default n
+	---help---
+	  Say Y here to get to see options for using your Linux host to run other
+	  operating systems inside virtual machines (guests).
+	  This option alone does not add any kernel code.
+
+	  If you say N, all options in this submenu will be skipped and disabled.
+
+if VIRTUALIZATION
+
+source drivers/virtio/Kconfig
+
+endif # VIRTUALIZATION
+
 source "lib/Kconfig"
-- 
1.6.3.3

[PATCH] arm: Add VIRTUALIZATION configuration menu and virtio options

[Russell King - ARM Linux]

On Wed, Sep 28, 2011 at 04:48:06PM +0100, Pawel Moll wrote:
> This patch adds menuconfig VIRTUALIZATION to arm Kconfig
> and includes virtio Kconfig in it.
> 
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> ---
>  arch/arm/Kconfig |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 3269576..426f330 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -2101,4 +2101,20 @@ source "security/Kconfig"
>  
>  source "crypto/Kconfig"
>  
> +menuconfig VIRTUALIZATION
> +	bool "Virtualization"
> +	default n

Please resubmit without the line above.  default n is default's default
default, so it's completely redundant by default.

[PATCH] arm: Add VIRTUALIZATION configuration menu and virtio options

[Pawel Moll]

> > This patch adds menuconfig VIRTUALIZATION to arm Kconfig
> > and includes virtio Kconfig in it.

I had another look and it's actually not needed any more, as since
e72542191cbba4cf7fda21cb22e26b42d7415daf "virtio: expose for
non-virtualization users too" the drivers/virtio/Kconfig is included in
drivers/Kconfig.

> Please resubmit without the line above.  default n is default's default
> default, so it's completely redundant by default.

We have 606 redundant defaults then:

$ find . -name Kconfig\* | xargs grep "default n" | wc -l
606

Not something that would make me sleepless ;-)

Cheers!

Pawe?