From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@linaro.org (Shawn Guo) Date: Sun, 2 Oct 2011 16:20:14 +0800 Subject: [PATCH v2] ARM: localtimer: add header linux/errno.h explicitly In-Reply-To: <1316798545-21128-1-git-send-email-shawn.guo@linaro.org> References: <1316798545-21128-1-git-send-email-shawn.guo@linaro.org> Message-ID: <1317543614-22922-1-git-send-email-shawn.guo@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Per the text in Documentation/SubmitChecklist as below, we should explicitly have header linux/errno.h in localtimer.h for ENXIO reference. 1: If you use a facility then #include the file that defines/declares that facility. Don't depend on other header files pulling in ones that you use. Otherwise, we may run into some compiling error like the following one, if any file includes localtimer.h without CONFIG_LOCAL_TIMERS defined. arch/arm/include/asm/localtimer.h: In function ?local_timer_setup?: arch/arm/include/asm/localtimer.h:53:10: error: ?ENXIO? undeclared (first use in this function) Signed-off-by: Shawn Guo --- Changes since v1: * Move the include towards the top of the file arch/arm/include/asm/localtimer.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/include/asm/localtimer.h b/arch/arm/include/asm/localtimer.h index 080d74f..ff66638 100644 --- a/arch/arm/include/asm/localtimer.h +++ b/arch/arm/include/asm/localtimer.h @@ -10,6 +10,8 @@ #ifndef __ASM_ARM_LOCALTIMER_H #define __ASM_ARM_LOCALTIMER_H +#include + struct clock_event_device; /* -- 1.7.4.1