From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: nr_cpus cmdline parameter not working
Date: Mon, 03 Oct 2011 09:47:52 -0400 [thread overview]
Message-ID: <1317649673.2703.0.camel@deneb.redhat.com> (raw)
In-Reply-To: <20111001162357.GH11710@n2100.arm.linux.org.uk>
On Sat, 2011-10-01 at 17:23 +0100, Russell King - ARM Linux wrote:
> On Wed, Sep 28, 2011 at 11:35:16AM -0400, Mark Salter wrote:
> > I noticed that nr_cpus=1 doesn't appear to have any effect on a
> > pandaboard (and probably others from the looks of things). This
> > changes seems to be needed, but I'm not really sure if this is
> > the right thing or not.
> >
> > diff --git a/arch/arm/mach-omap2/omap-smp.c b/arch/arm/mach-omap2/omap-smp.c
> > index ce65e93..a1198ac 100644
> > --- a/arch/arm/mach-omap2/omap-smp.c
> > +++ b/arch/arm/mach-omap2/omap-smp.c
> > @@ -117,6 +117,9 @@ void __init smp_init_cpus(void)
> > ncores = NR_CPUS;
> > }
> >
> > + if (ncores > nr_cpu_ids)
> > + ncores = nr_cpu_ids;
> > +
>
> This potentially affects all SMP platforms, so the patch needs to be
> bigger than this.
>
> Also, I think the test above should be modified to use nr_cpu_ids
> rather than NR_CPUS, to be inline with what x86 does:
>
> /* nr_cpu_ids could be reduced via nr_cpus= */
> if (possible > nr_cpu_ids) {
> printk(KERN_WARNING
> "%d Processors exceeds NR_CPUS limit of %d\n",
> possible, nr_cpu_ids);
> possible = nr_cpu_ids;
> }
>
> (This is essentially the same check that we're doing.)
>
> Could you have a look at this and cook up another patch covering the
> other SMP platforms please?
Ok, I'll do that.
prev parent reply other threads:[~2011-10-03 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 15:35 nr_cpus cmdline parameter not working Mark Salter
2011-10-01 16:23 ` Russell King - ARM Linux
2011-10-03 13:47 ` Mark Salter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317649673.2703.0.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).