From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/11] ARM: at91/pata: use gpio_is_valid to check the gpio
Date: Sun, 16 Oct 2011 21:09:13 +0200 [thread overview]
Message-ID: <1318792160-23279-4-git-send-email-plagnioj@jcrosoft.com> (raw)
In-Reply-To: <20111016190528.GI1459@game.jcrosoft.org>
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/ata/pata_at91.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
index 960c725..3915353 100644
--- a/drivers/ata/pata_at91.c
+++ b/drivers/ata/pata_at91.c
@@ -360,7 +360,7 @@ static int __devinit pata_at91_probe(struct platform_device *pdev)
ap->flags |= ATA_FLAG_SLAVE_POSS;
ap->pio_mask = ATA_PIO4;
- if (!irq) {
+ if (!gpio_is_valid(irq)) {
ap->flags |= ATA_FLAG_PIO_POLLING;
ata_port_desc(ap, "no IRQ, using PIO polling");
}
@@ -414,8 +414,8 @@ static int __devinit pata_at91_probe(struct platform_device *pdev)
host->private_data = info;
- return ata_host_activate(host, irq ? gpio_to_irq(irq) : 0,
- irq ? ata_sff_interrupt : NULL,
+ return ata_host_activate(host, gpio_is_valid(irq) ? gpio_to_irq(irq) : 0,
+ gpio_is_valid(irq) ? ata_sff_interrupt : NULL,
irq_flags, &pata_at91_sht);
err_put:
--
1.7.7
next prev parent reply other threads:[~2011-10-16 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 19:05 [PATCH 0/11 v3] ARM: AT91: update gpio implementation Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 01/11] ARM: at91/gpio: make gpio register base soc independant Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 02/11] ARM: at91/boards: use -EINVAL for invalid gpio Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 03/11] ARM: at91/soc: use gpio_is_valid to check the gpio Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-10-17 10:54 ` [PATCH 04/11] ARM: at91/pata: " Sergei Shtylyov
2011-10-17 12:24 ` Jean-Christophe PLAGNIOL-VILLARD
2011-10-18 11:21 ` Sergei Shtylyov
2011-10-18 11:24 ` Sergei Shtylyov
2011-10-16 19:09 ` [PATCH 05/11] ARM: at91/ide: " Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 06/11] ARM: at91/mmc: " Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 07/11] ARM: at92/nand: " Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 08/11] ARM: at92/udc: " Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 09/11] ARM: at92/ohci: " Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 10/11] ARM: at91/gpio: drop PIN_BASE Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 19:09 ` [PATCH 11/11] ARM: at91/gpio: fix display of number of irq setuped Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318792160-23279-4-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).