From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 0/4] simplify remapping a resource for drivers
Date: Mon, 24 Oct 2011 10:42:05 +0200 [thread overview]
Message-ID: <1319445729-14841-1-git-send-email-w.sang@pengutronix.de> (raw)
Mostly all platform drivers need to do something like this to get a ioremapped
pointer from a resource (and some have multiple resources to be remapped):
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
dev_err(&pdev->dev, "can't get device resources\n");
return -ENOENT;
}
res_size = resource_size(res);
if (!devm_request_mem_region(&pdev->dev, res->start, res_size, res->name)) {
dev_err(&pdev->dev, "can't allocate %d bytes at %d address\n",
res_size, res->start);
return -EBUSY;
}
priv->base = devm_ioremap_nocache(&pdev->dev, res->start, res_size);
if (priv->base) {
dev_err(&pdev->dev, "ioremap failed\n");
return -ENOMEM;
}
In case of not using managed devices, there is also code for cleaning up when
hitting an error. After this series, the same can be done with:
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
err = devm_resource_to_mapped_ptr(&pdev->dev, res, &priv->base);
if (err)
return err;
The new function will perform all necessary checks and return with consistent
error codes and messages on failures. It also prevents common mistakes like
using a wrong type for res_size or not calling the _nocache-variant of ioremap
if the resource is not marked otherwise. Because the new functions works with
the struct device (plus a resource), it will probably be useful even if
platform drivers run out of fashion.
The first two patches are minor cleanups on devres found while working on the code.
The third patch adds the new function. The fourth patch is an example, so we have a
simple use-case for the proposed functionality.
The series can also be fetched from:
git://git.pengutronix.de/git/wsa/linux-2.6.git resource_to_ptr
Looking forward to reviews and comments.
Thanks,
Wolfram
Wolfram Sang (4):
Documentation: devres: add allocation functions to list of supported calls
lib: devres: add annotations for #endif
lib: devres: add function which remaps a given resource
watchdog: imx2: simplify resource allocation
Documentation/driver-model/devres.txt | 5 +++
drivers/watchdog/imx2_wdt.c | 22 ++-----------
include/linux/device.h | 3 ++
lib/devres.c | 56 +++++++++++++++++++++++++++++++-
4 files changed, 65 insertions(+), 21 deletions(-)
--
1.7.6.3
next reply other threads:[~2011-10-24 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 8:42 Wolfram Sang [this message]
[not found] ` <1319445729-14841-5-git-send-email-w.sang@pengutronix.de>
2011-10-24 11:56 ` [RFC 4/4] watchdog: imx2: simplify resource allocation Grant Likely
[not found] ` <1319445729-14841-2-git-send-email-w.sang@pengutronix.de>
2011-10-24 15:25 ` [RFC 1/4] Documentation: devres: add allocation functions to list of supported calls Tejun Heo
[not found] ` <1319445729-14841-4-git-send-email-w.sang@pengutronix.de>
2011-10-24 11:56 ` [RFC 3/4] lib: devres: add convenience function to remap a resource Grant Likely
2011-10-24 15:44 ` Tejun Heo
2011-10-24 15:43 ` Tejun Heo
2011-10-24 20:09 ` Wolfram Sang
2011-10-24 20:19 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319445729-14841-1-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).