From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67EF7C3DA4A for ; Thu, 8 Aug 2024 07:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lyT4LPycbQhR91Srg9X3tvzfQSxZ58CaFb8fLF9nTlk=; b=fP8+on2tUFsuvuvyQHOwjovqLv wUi4sFjJR64SmtKlvtUQVaKvxIueFlbbfFlM1y6QCoOvYL9/MXjRQY4PY4iw0Q7sANsh9eZgLLYu/ IpugOidGGJBW0J57N1GWI+69atZrdmN5zWs4PF7wPDFj1+RHw9gx7Ya+6283YoFGhvqOy4MzZCzee 1dYhCl0Ri7ivnzM9VJ3rzBBP8+HRSaKj/bH6jYRRkfrJW/th20/1Cv6jz6cL6wiPoBuHpemQQNbWy M+4sLhM3MMKE9/yXruKy4Ok4ORXWcr0xV0yQVpkyAf+IeNHJ9JRQMb1i850tWECiF1NiKc2yuP2oL LtgdKrIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbxk5-00000007STP-2Iyf; Thu, 08 Aug 2024 07:39:25 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbxjW-00000007SPH-0XiO for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2024 07:38:51 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 4787ck67125647; Thu, 8 Aug 2024 02:38:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1723102726; bh=lyT4LPycbQhR91Srg9X3tvzfQSxZ58CaFb8fLF9nTlk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=zRbIfqE2pNcWN5kZ6J2+3MOOSjAnFc1/ok77tdzb3M4TLuihzq/0663vBKLUutTOf sZQWUAecROPdx0CPzHDgiwN54dOlExUgNgKjE3RozebovxLOBty3+KwGLyOm3g0WMo /dewr5d0hP0DJuf12qTJJbKxWLIDr/gDjdWHtEcw= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 4787ckip008043 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Aug 2024 02:38:46 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 8 Aug 2024 02:38:46 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 8 Aug 2024 02:38:45 -0500 Received: from [10.24.68.216] (a0498981-hp-z2-tower-g5-workstation.dhcp.ti.com [10.24.68.216]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4787cgrG016932; Thu, 8 Aug 2024 02:38:42 -0500 Message-ID: <1319a6ac-6784-45d6-8a0e-170e40d3aa18@ti.com> Date: Thu, 8 Aug 2024 13:08:41 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1 Content-Language: en-US To: Neha Malcom Francis , , CC: , , , , , , , , References: <20240807101624.2713490-1-b-kapoor@ti.com> <8fa39624-9a92-404d-8651-9ade5700a7d3@ti.com> From: Bhavya Kapoor In-Reply-To: <8fa39624-9a92-404d-8651-9ade5700a7d3@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_003850_352675_8CF844D8 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Neha, On 08/08/24 11:51 am, Neha Malcom Francis wrote: > Hi Bhavya > > On 07/08/24 15:46, Bhavya Kapoor wrote: >> mmc1 was not functional since pin mux for clklb was not present. >> Thus, add clklb pin mux to get MMC working. >> >> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for >> AM68 SK base board") >> Signed-off-by: Bhavya Kapoor >> --- >> >> rebased to next-20240807 >> >>   arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts >> b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts >> index 90dbe31c5b81..d5ceab79536c 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts >> @@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins { >>           pinctrl-single,pins = < >>               J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */ >>               J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */ >> +            J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */ >>               J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */ >>               J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */ >>               J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */ > > How is this different from the P23 pinmux for MMC1_CLK? Could you > explain what CLKLB is, since it doesn't have a ball number I'm finding > it difficult to understand what it is? > This pin needs to be setup so that MMC_CLK is looped back at pad level for highspeed SDIO operations (has been same across K3 family). MMC0/1 has this pin configured as INPUT by reset default as these have boot media  These pinmuxes are derived from pinmux file shared by EVM team during wakeup/board bringup. Regards