linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 10/16] ARM: LPAE: Invalidate the TLB before freeing the PMD
Date: Mon,  7 Nov 2011 16:16:52 +0000	[thread overview]
Message-ID: <1320682618-1182-11-git-send-email-catalin.marinas@arm.com> (raw)
In-Reply-To: <1320682618-1182-1-git-send-email-catalin.marinas@arm.com>

Similar to the PTE freeing, this patch introduced __pmd_free_tlb() which
invalidates the TLB before freeing a PMD page. This is needed because on
newer processors the entry in the upper page table may be cached by the
TLB and point to random data after the PMD has been freed.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
 arch/arm/include/asm/tlb.h |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h
index b509e44..5d3ed7e3 100644
--- a/arch/arm/include/asm/tlb.h
+++ b/arch/arm/include/asm/tlb.h
@@ -202,8 +202,17 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte,
 	tlb_remove_page(tlb, pte);
 }
 
+static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp,
+				  unsigned long addr)
+{
+#ifdef CONFIG_ARM_LPAE
+	tlb_add_flush(tlb, addr);
+	tlb_remove_page(tlb, virt_to_page(pmdp));
+#endif
+}
+
 #define pte_free_tlb(tlb, ptep, addr)	__pte_free_tlb(tlb, ptep, addr)
-#define pmd_free_tlb(tlb, pmdp, addr)	pmd_free((tlb)->mm, pmdp)
+#define pmd_free_tlb(tlb, pmdp, addr)	__pmd_free_tlb(tlb, pmdp, addr)
 #define pud_free_tlb(tlb, pudp, addr)	pud_free((tlb)->mm, pudp)
 
 #define tlb_migrate_finish(mm)		do { } while (0)

  parent reply	other threads:[~2011-11-07 16:16 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 16:16 [PATCH v8 00/16] ARM: Add support for the Large Physical Address Extensions Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 01/16] ARM: pgtable: switch to use pgtable-nopud.h Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 02/16] ARM: pgtable: Fix compiler warning in ioremap.c introduced by nopud Catalin Marinas
2011-11-10 22:42   ` Russell King - ARM Linux
2011-11-07 16:16 ` [PATCH v8 03/16] ARM: LPAE: Move page table maintenance macros to pgtable-2level.h Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 04/16] ARM: LPAE: Move the FSR definitions to separate files Catalin Marinas
2011-11-10 22:45   ` Russell King - ARM Linux
2011-11-10 23:44   ` Tony Lindgren
2011-11-07 16:16 ` [PATCH v8 05/16] ARM: LPAE: Factor out classic-MMU specific code into proc-v7-2level.S Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 06/16] ARM: LPAE: add ISBs around MMU enabling code Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 07/16] ARM: LPAE: Introduce the 3-level page table format definitions Catalin Marinas
2011-11-10 21:53   ` Nicolas Pitre
2011-11-11 10:49     ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 08/16] ARM: LPAE: Page table maintenance for the 3-level format Catalin Marinas
2011-11-10 21:59   ` Nicolas Pitre
2011-11-11 10:54     ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 09/16] ARM: LPAE: MMU setup for the 3-level page table format Catalin Marinas
2011-11-10 22:24   ` Nicolas Pitre
2011-11-10 22:38     ` Russell King - ARM Linux
2011-11-11 11:17       ` Catalin Marinas
2011-11-11 11:00     ` Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas [this message]
2011-11-07 16:16 ` [PATCH v8 11/16] ARM: LPAE: Add fault handling support Catalin Marinas
2011-11-10 22:46   ` Russell King - ARM Linux
2011-11-07 16:16 ` [PATCH v8 12/16] ARM: LPAE: Add context switching support Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 13/16] ARM: LPAE: Add identity mapping support for the 3-level page table format Catalin Marinas
2011-11-10 22:55   ` Russell King - ARM Linux
2011-11-11 11:36     ` Catalin Marinas
2011-11-11 11:58       ` Will Deacon
2011-11-07 16:16 ` [PATCH v8 14/16] ARM: LPAE: mark memory banks with start > ULONG_MAX as highmem Catalin Marinas
2011-11-09 20:41   ` Nicolas Pitre
2011-11-07 16:16 ` [PATCH v8 15/16] ARM: LPAE: add support for ATAG_MEM64 Catalin Marinas
2011-11-08 16:54   ` Stephen Boyd
2011-11-08 16:59     ` Catalin Marinas
2011-11-08 23:38   ` Nicolas Pitre
2011-11-09  0:24     ` Will Deacon
2011-11-09 10:44     ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 16/16] ARM: LPAE: Add the Kconfig entries Catalin Marinas
2011-11-10 22:57   ` Russell King - ARM Linux
2011-11-11 11:46     ` Catalin Marinas
2011-11-11 13:24       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320682618-1182-11-git-send-email-catalin.marinas@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).