linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: omap2: fix build failure
@ 2011-11-08  4:34 tom.leiming at gmail.com
  2011-11-08 19:24 ` Kevin Hilman
  0 siblings, 1 reply; 5+ messages in thread
From: tom.leiming at gmail.com @ 2011-11-08  4:34 UTC (permalink / raw)
  To: linux-arm-kernel

From: Ming Lei <tom.leiming@gmail.com>

The patch fixes the compile failure:

  CC      arch/arm/mach-omap2/cpuidle34xx.o
arch/arm/mach-omap2/cpuidle34xx.c:317:12: error: 'THIS_MODULE'
undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/cpuidle34xx.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2
make: *** Waiting for unfinished jobs....

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 arch/arm/mach-omap2/cpuidle34xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c
index 1fe35c2..158c17e 100644
--- a/arch/arm/mach-omap2/cpuidle34xx.c
+++ b/arch/arm/mach-omap2/cpuidle34xx.c
@@ -24,6 +24,7 @@
 
 #include <linux/sched.h>
 #include <linux/cpuidle.h>
+#include <linux/module.h>
 
 #include <plat/prcm.h>
 #include <plat/irqs.h>
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] arm: omap2: fix build failure
  2011-11-08  4:34 [PATCH] arm: omap2: fix build failure tom.leiming at gmail.com
@ 2011-11-08 19:24 ` Kevin Hilman
  2011-11-17  3:00   ` Ming Lei
  0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2011-11-08 19:24 UTC (permalink / raw)
  To: linux-arm-kernel

tom.leiming at gmail.com writes:

> From: Ming Lei <tom.leiming@gmail.com>
>
> The patch fixes the compile failure:
>
>   CC      arch/arm/mach-omap2/cpuidle34xx.o
> arch/arm/mach-omap2/cpuidle34xx.c:317:12: error: 'THIS_MODULE'
> undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/cpuidle34xx.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2
> make: *** Waiting for unfinished jobs....
>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>

FYI...

Tony has already queued fix for this in his fixes branch.

     http://marc.info/?l=linux-arm-kernel&m=132071036621713&w=2

Kevin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] arm: omap2: fix build failure
  2011-11-08 19:24 ` Kevin Hilman
@ 2011-11-17  3:00   ` Ming Lei
  2011-11-17 19:36     ` Kevin Hilman
  0 siblings, 1 reply; 5+ messages in thread
From: Ming Lei @ 2011-11-17  3:00 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Wed, Nov 9, 2011 at 3:24 AM, Kevin Hilman <khilman@ti.com> wrote:
> tom.leiming at gmail.com writes:
>
>> From: Ming Lei <tom.leiming@gmail.com>
>>
>> The patch fixes the compile failure:
>>
>> ? CC ? ? ?arch/arm/mach-omap2/cpuidle34xx.o
>> arch/arm/mach-omap2/cpuidle34xx.c:317:12: error: 'THIS_MODULE'
>> undeclared here (not in a function)
>> make[1]: *** [arch/arm/mach-omap2/cpuidle34xx.o] Error 1
>> make: *** [arch/arm/mach-omap2] Error 2
>> make: *** Waiting for unfinished jobs....
>>
>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>
> FYI...
>
> Tony has already queued fix for this in his fixes branch.
>
> ? ? http://marc.info/?l=linux-arm-kernel&m=132071036621713&w=2

The fix is not merged into 3.2.0-rc2-next-20111116+ yet...

thanks,
-- 
Ming Lei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] arm: omap2: fix build failure
  2011-11-17  3:00   ` Ming Lei
@ 2011-11-17 19:36     ` Kevin Hilman
  2011-11-18  1:16       ` Ming Lei
  0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2011-11-17 19:36 UTC (permalink / raw)
  To: linux-arm-kernel

Ming Lei <tom.leiming@gmail.com> writes:

> On Wed, Nov 9, 2011 at 3:24 AM, Kevin Hilman <khilman@ti.com> wrote:
>> tom.leiming at gmail.com writes:
>>
>>> From: Ming Lei <tom.leiming@gmail.com>
>>>
>>> The patch fixes the compile failure:
>>>
>>> ? CC ? ? ?arch/arm/mach-omap2/cpuidle34xx.o
>>> arch/arm/mach-omap2/cpuidle34xx.c:317:12: error: 'THIS_MODULE'
>>> undeclared here (not in a function)
>>> make[1]: *** [arch/arm/mach-omap2/cpuidle34xx.o] Error 1
>>> make: *** [arch/arm/mach-omap2] Error 2
>>> make: *** Waiting for unfinished jobs....
>>>
>>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>>
>> FYI...
>>
>> Tony has already queued fix for this in his fixes branch.
>>
>> ? ? http://marc.info/?l=linux-arm-kernel&m=132071036621713&w=2
>
> The fix is not merged into 3.2.0-rc2-next-20111116+ yet...

OK, but that doesn't mean you have to keep sending it.  It just means
Tony's fixes branch isn't in -next (yet.)

Kevin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] arm: omap2: fix build failure
  2011-11-17 19:36     ` Kevin Hilman
@ 2011-11-18  1:16       ` Ming Lei
  0 siblings, 0 replies; 5+ messages in thread
From: Ming Lei @ 2011-11-18  1:16 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Fri, Nov 18, 2011 at 3:36 AM, Kevin Hilman <khilman@ti.com> wrote:

> OK, but that doesn't mean you have to keep sending it. ?It just means
> Tony's fixes branch isn't in -next (yet.)

I do not care about which one is merged, but don't want to apply
the fix patch manually for each test, :-)

In fact, there are several other non-merged build failures for omap build,
looks like the process is a bit slow, :-)

thanks,
-- 
Ming Lei

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-11-18  1:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-08  4:34 [PATCH] arm: omap2: fix build failure tom.leiming at gmail.com
2011-11-08 19:24 ` Kevin Hilman
2011-11-17  3:00   ` Ming Lei
2011-11-17 19:36     ` Kevin Hilman
2011-11-18  1:16       ` Ming Lei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).