From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC8F5C05027 for ; Fri, 17 Feb 2023 08:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bO2IpqEUD3TjMB+9Ym6M8+i8MTKPrVcMrQ9SQn6K+M4=; b=FHWjdwcQSi7n7S h8/sm9m1qSpTR4kd1g4LDdhXPaVQCYF149OL8rCqO107Ka3sO3DXIgy9VoaCZ1qK2FuesSgHm6rXH cZdLlaN92x2uv4PxzBWReVis4ZkChvli/zBnNikhqU8PJNy3nqlN1FI7ZAl/FFJLJg45nQeFsp3dJ XNhrp5o49kXAZjJE5SuSH8kpuZw9u5Jv1NDWDc2+6gvYNcObuUqLSm2AwkwYLaKmdF+BkEGF3cgUX RohGiklxdpEaNgImd0jby+qKaXv8kv53sNsyUM8DS3O37Zvxk8v6UMn3mVwWt7a92W+O+3dLFSRa+ imvz+lk8b1X/9qN9qHXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSvwu-00DH9R-Sc; Fri, 17 Feb 2023 08:18:33 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSvwr-00DH8B-Fr for linux-arm-kernel@lists.infradead.org; Fri, 17 Feb 2023 08:18:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676621909; x=1708157909; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FjGA5EgNa4NYOuHwjtG2x3GPMclXf8S24b/yy7KMZGM=; b=kSQy9/WNxWzdiCnvPHRnYXmaW8veRWmVJwudaDVXxsvMtEmhMcKdQ71h PdDDNfod3VAaL77bpo2vSTPbk7lXaFX4f031pQN0Kyf5sxSDIrNKg0rE2 cbf7JD8KDWZ+Gk/MLUq9GkxUDbSS8GaqHR+9DBqV8TbynYJSmWQtpYJc0 q1lPJy4B0XSrQS8Z5AeiDNK1XwhegKiMLcl8lJ+4LrevUlDofyZBWKX4W n2qlGV9a4Iy53oGbmbwlhv2zJOnbkQzNWnE1OpEjlH2iLdeJQH3MhYy7M 8kM85J/iecFhwKOuUFCSY9P24IDKqMD4P7psFYiEnmW5jjqNbvj+93jYZ Q==; X-IronPort-AV: E=Sophos;i="5.97,304,1669071600"; d="scan'208";a="29148279" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 17 Feb 2023 09:18:25 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 17 Feb 2023 09:18:26 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 17 Feb 2023 09:18:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676621906; x=1708157906; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FjGA5EgNa4NYOuHwjtG2x3GPMclXf8S24b/yy7KMZGM=; b=UjsfVGJ1VaKZwlcqrObDgkBGxR9tOwzlStTRa58KQ2Zfhauj780BDWQa livcGZk9glmf6FXHT2fovqzrd2Y6A73VMw9Huvik6Kr04aBfzxIII2Tyq 3AOb789By1KAwKEnql+FptnEeZKWZeinWNZhctdBCFNHXmCl1hbqC+U20 F/RfY9V6FnAjpGzaCgP8/BrDGcrF+5euzsbWIDW0IMATSeyHr5xPAENLs m02f0bGpDXApzvbZnRVnU6s/foeDOAU+SGNgDM+cXKAZzpvTB2sUurYJh Y6dIGp/0VzHYs4X0q/ttyQuYDOKFO0BQZI2K9CnnSj2M+MhUWCkCqfvz8 Q==; X-IronPort-AV: E=Sophos;i="5.97,304,1669071600"; d="scan'208";a="29148255" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 17 Feb 2023 09:18:04 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 346C5280056; Fri, 17 Feb 2023 09:18:03 +0100 (CET) From: Alexander Stein To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Liu Ying Cc: marex@denx.de, stefan@agner.ch, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, krzysztof.kozlowski@linaro.org, LW@karo-electronics.de Subject: Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support Date: Fri, 17 Feb 2023 09:18:00 +0100 Message-ID: <13207614.uLZWGnKmhe@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230217065407.2259731-1-victor.liu@nxp.com> References: <20230217065407.2259731-1-victor.liu@nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230217_001829_949491_A9589807 X-CRM114-Status: GOOD ( 24.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying: > Hi, > = > This patch set aims to add i.MX93 LCDIF display controller support > in the existing LCDIF DRM driver. The LCDIF embedded in i.MX93 SoC > is essentially the same to those embedded in i.MX8mp SoC. Through > internal bridges, i.MX93 LCDIF may drive a MIPI DSI display or a LVDS > display or a parallel display. > = > Patch 1/6 adds device tree binding support for i.MX93 LCDIF in the > existing fsl,lcdif.yaml. > = > Patch 2/6 drops lcdif->bridge NULL pointer check as a cleanup patch. > = > Patch 3/6~5/6 prepare for adding i.MX93 LCDIF support step by step. > = > Patch 6/6 adds i.MX93 LCDIF compatible string as the last step of > adding i.MX93 LCDIF support. Thanks for the series. I could test this on my TQMa93xxLA/MBa93xxCA with a = single LVDS display attached, so no DSI or parallel display. Hence I could = not = test the bus format and flags checks, but they look okay. So you can add Tested-by: Alexander Stein to the whole series as well. One thing I noticed is that, sometimes it seems that before probing lcdif m= y = system completely freezes. Adding some debug output it seems that's during = powering up the IMX93_MEDIABLK_PD_LCDIF power domain there is some race = condition. But adding more more detailed output made the problem go away. Did you notice something similar? It might be a red hering though. Best regards, Alexander > = > v3->v4: > * Improve warning message when ignoring invalid LCDIF OF endpoint ids in > patch 5/6. (Alexander) > * Use 'new_{c,p}state' instead of 'new_{crtc,plane}_state' in patch 3/6. > (Alexander) > * Simplify lcdif_crtc_reset() by calling lcdif_crtc_atomic_destroy_state() > in patch 3/6. (Alexander) > * Add '!crtc->state' check in lcdif_crtc_atomic_duplicate_state() in patch > 3/6. (Alexander) > * Collect Alexander's R-b tags on patch 1/6, 2/6 and 6/6. > = > v2->v3: > * Fix a trivial typo in patch 6/6's commit message. > = > v1->v2: > * Add Krzysztof's A-b and Marek's R-b tags on patch 1/6. > * Split patch 2/2 in v1 into patch 2/6~6/6 in v2. (Marek, Alexander) > * Drop '!remote ||' from lcdif_attach_bridge(). (Lothar) > * Add comment on the 'base' member of lcdif_crtc_state structure to > note it should always be the first member. (Lothar) > * Drop unneeded 'bridges' member from lcdif_drm_private structure. > * Drop a comment about bridge input bus format from > lcdif_crtc_atomic_check(). > = > Liu Ying (6): > dt-bindings: lcdif: Add i.MX93 LCDIF support > drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge > drm: lcdif: Determine bus format and flags in ->atomic_check() > drm: lcdif: Check consistent bus format and flags across first bridges > drm: lcdif: Add multiple encoders and first bridges support > drm: lcdif: Add i.MX93 LCDIF compatible string > = > .../bindings/display/fsl,lcdif.yaml | 7 +- > drivers/gpu/drm/mxsfb/lcdif_drv.c | 71 ++++++- > drivers/gpu/drm/mxsfb/lcdif_drv.h | 5 +- > drivers/gpu/drm/mxsfb/lcdif_kms.c | 198 ++++++++++++------ > 4 files changed, 206 insertions(+), 75 deletions(-) -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel