Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DMA: PL330: Fix build warning
Date: Thu, 10 Nov 2011 02:00:58 -0800	[thread overview]
Message-ID: <1320919258.2156.5.camel@Joe-Laptop> (raw)
In-Reply-To: <1320918283.32205.1206.camel@vkoul-udesk3>

On Thu, 2011-11-10 at 15:14 +0530, Vinod Koul wrote:
> On Thu, 2011-11-03 at 15:48 +0900, Boojin Kim wrote:
> > This patch adds to fix the build warning as following.
> > 
> > drivers/dma/pl330.c: In function 'pl330_probe':
> > drivers/dma/pl330.c:859: warning: comparison of distinct pointer types lacks a cast
> > 
> > Signed-off-by: Boojin Kim <boojin.kim@samsung.com>
> > ---
> >  drivers/dma/pl330.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> > index 621134f..379d928 100644
> > --- a/drivers/dma/pl330.c
> > +++ b/drivers/dma/pl330.c
> > @@ -856,7 +856,8 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
> >  	INIT_LIST_HEAD(&pd->channels);
> >  
> >  	/* Initialize channel parameters */
> > -	num_chan = max(pdat ? pdat->nr_valid_peri : 0, (u8)pi->pcfg.num_chan);
> > +	num_chan = max(pdat ? (int)pdat->nr_valid_peri : 0,
> > +					(int)pi->pcfg.num_chan);
> >  	pdmac->peripherals = kzalloc(num_chan * sizeof(*pch), GFP_KERNEL);
> >  
> >  	for (i = 0; i < num_chan; i++) {
> 
> Applied Thanks

Perhaps
	max_t(int, pdat ? pdat->nr_valid_peri : 0, pi->pcfg.num_chan);

      reply	other threads:[~2011-11-10 10:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-03  6:48 [PATCH] DMA: PL330: Fix build warning Boojin Kim
2011-11-10  9:44 ` Vinod Koul
2011-11-10 10:00   ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320919258.2156.5.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox