linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 14/15] ARM: LPAE: mark memory banks with start > ULONG_MAX as highmem
Date: Mon, 14 Nov 2011 16:23:50 +0000	[thread overview]
Message-ID: <1321287831-24560-15-git-send-email-catalin.marinas@arm.com> (raw)
In-Reply-To: <1321287831-24560-1-git-send-email-catalin.marinas@arm.com>

From: Will Deacon <will.deacon@arm.com>

Memory banks living outside of the 32-bit physical address
space do not have a 1:1 pa <-> va mapping and therefore the
__va macro may wrap.

This patch ensures that such banks are marked as highmem so
that the Kernel doesn't try to split them up when it sees that
the wrapped virtual address overlaps the vmalloc space.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
---
 arch/arm/mm/mmu.c |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
index 1935311..b836d6b 100644
--- a/arch/arm/mm/mmu.c
+++ b/arch/arm/mm/mmu.c
@@ -799,6 +799,9 @@ void __init sanity_check_meminfo(void)
 		struct membank *bank = &meminfo.bank[j];
 		*bank = meminfo.bank[i];
 
+		if (bank->start > ULONG_MAX)
+			highmem = 1;
+
 #ifdef CONFIG_HIGHMEM
 		if (__va(bank->start) >= vmalloc_min ||
 		    __va(bank->start) < (void *)PAGE_OFFSET)
@@ -810,7 +813,7 @@ void __init sanity_check_meminfo(void)
 		 * Split those memory banks which are partially overlapping
 		 * the vmalloc area greatly simplifying things later.
 		 */
-		if (__va(bank->start) < vmalloc_min &&
+		if (!highmem && __va(bank->start) < vmalloc_min &&
 		    bank->size > vmalloc_min - __va(bank->start)) {
 			if (meminfo.nr_banks >= NR_BANKS) {
 				printk(KERN_CRIT "NR_BANKS too low, "
@@ -831,6 +834,17 @@ void __init sanity_check_meminfo(void)
 		bank->highmem = highmem;
 
 		/*
+		 * Highmem banks not allowed with !CONFIG_HIGHMEM.
+		 */
+		if (highmem) {
+			printk(KERN_NOTICE "Ignoring RAM at %.8llx-%.8llx "
+			       "(!CONFIG_HIGHMEM).\n",
+			       (unsigned long long)bank->start,
+			       (unsigned long long)bank->start + bank->size - 1);
+			continue;
+		}
+
+		/*
 		 * Check whether this memory bank would entirely overlap
 		 * the vmalloc area.
 		 */

  parent reply	other threads:[~2011-11-14 16:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 16:23 [PATCH v9 00/15] ARM: Add support for the Large Physical Address Extensions Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 01/15] ARM: pgtable: Fix compiler warning in ioremap.c introduced by nopud Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 02/15] ARM: pgtable: switch to use pgtable-nopud.h Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 03/15] ARM: LPAE: Move page table maintenance macros to pgtable-2level.h Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 04/15] ARM: LPAE: Move the FSR definitions to separate files Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 05/15] ARM: LPAE: Factor out classic-MMU specific code into proc-v7-2level.S Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 06/15] ARM: LPAE: add ISBs around MMU enabling code Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 07/15] ARM: LPAE: Introduce the 3-level page table format definitions Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 08/15] ARM: LPAE: Page table maintenance for the 3-level format Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 09/15] ARM: LPAE: MMU setup for the 3-level page table format Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 10/15] ARM: LPAE: Invalidate the TLB before freeing the PMD Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 11/15] ARM: LPAE: Add fault handling support Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 12/15] ARM: LPAE: Add context switching support Catalin Marinas
2011-11-14 16:23 ` [PATCH v9 13/15] ARM: LPAE: Add identity mapping support for the 3-level page table format Catalin Marinas
2011-11-14 16:23 ` Catalin Marinas [this message]
2011-11-14 16:23 ` [PATCH v9 15/15] ARM: LPAE: Add the Kconfig entries Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321287831-24560-15-git-send-email-catalin.marinas@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).