From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Tue, 15 Nov 2011 17:18:14 -0800 Subject: [PATCH 4/4] mmc: Add mmc_host_ logging In-Reply-To: References: <631c53d126feff0a99b61d9c9a00b308d2b638ee.1321398815.git.joe@perches.com> <1321405049.21286.35.camel@Joe-Laptop> Message-ID: <1321406294.9189.2.camel@Joe-Laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2011-11-16 at 10:14 +0900, NamJae Jeon wrote: > 2011/11/16 Joe Perches : > > On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote: > >> 2011/11/16 Joe Perches : > >> > Centralize the pr_ uses of mmc_hostname into specific > >> > mmc_host_ calls to allow a flexible presentation style > >> > and shorten the code a bit. > >> I don't know why pr_info should be surely replaced by mmc_host_info. > >> if it is needed for only host name, I think that existing > >> pr_info/err/debug is sufficient. > > Please trim your replies and read the patch description. > my concern is that they feel confuse when coder add print code because > they should use mmc_host for hostname, and pr_ is used > in the other case. That's one point of view. It is the same issue though as using dev_ when you have a struct device * and also using pr_ otherwise.