* [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its implementation
@ 2011-11-17 22:43 Thomas Meyer
2011-12-07 6:57 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Meyer @ 2011-11-17 22:43 UTC (permalink / raw)
To: linux-arm-kernel
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
--- a/arch/arm/plat-s3c24xx/dma.c 2011-11-07 19:37:20.736205210 +0100
+++ b/arch/arm/plat-s3c24xx/dma.c 2011-11-08 11:03:41.719762852 +0100
@@ -1437,11 +1437,10 @@ int __init s3c24xx_dma_init_map(struct s
size_t map_sz = sizeof(*nmap) * sel->map_size;
int ptr;
- nmap = kmalloc(map_sz, GFP_KERNEL);
+ nmap = kmemdup(sel->map, map_sz, GFP_KERNEL);
if (nmap == NULL)
return -ENOMEM;
- memcpy(nmap, sel->map, map_sz);
memcpy(&dma_sel, sel, sizeof(*sel));
dma_sel.map = nmap;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its implementation
2011-11-17 22:43 [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its implementation Thomas Meyer
@ 2011-12-07 6:57 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2011-12-07 6:57 UTC (permalink / raw)
To: linux-arm-kernel
Thomas Meyer wrote:
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/memdup.cocci.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> --- a/arch/arm/plat-s3c24xx/dma.c 2011-11-07 19:37:20.736205210 +0100
> +++ b/arch/arm/plat-s3c24xx/dma.c 2011-11-08 11:03:41.719762852 +0100
> @@ -1437,11 +1437,10 @@ int __init s3c24xx_dma_init_map(struct s
> size_t map_sz = sizeof(*nmap) * sel->map_size;
> int ptr;
>
> - nmap = kmalloc(map_sz, GFP_KERNEL);
> + nmap = kmemdup(sel->map, map_sz, GFP_KERNEL);
> if (nmap == NULL)
> return -ENOMEM;
>
> - memcpy(nmap, sel->map, map_sz);
> memcpy(&dma_sel, sel, sizeof(*sel));
>
> dma_sel.map = nmap;
Yes, looks ok to me, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-07 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-17 22:43 [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its implementation Thomas Meyer
2011-12-07 6:57 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).