From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx5: Fix checkpatch warnings in cpu-imx5.c
Date: Mon, 21 Nov 2011 17:24:17 -0800 [thread overview]
Message-ID: <1321925057.1131.2.camel@Joe-Laptop> (raw)
In-Reply-To: <1321900012-8351-2-git-send-email-fabio.estevam@freescale.com>
On Mon, 2011-11-21 at 16:26 -0200, Fabio Estevam wrote:
> WARNING: line over 80 characters
Trivia...
> #70: FILE: arm/mach-imx/cpu-imx5.c:70:
> + if (mx51_revision() < IMX_CHIP_REVISION_3_0 && (elf_hwcap & HWCAP_NEON)) {
[]
> diff --git a/arch/arm/mach-imx/cpu-imx5.c b/arch/arm/mach-imx/cpu-imx5.c
[]
> @@ -67,7 +67,8 @@ static int __init mx51_neon_fixup(void)
> if (!cpu_is_mx51())
> return 0;
>
> - if (mx51_revision() < IMX_CHIP_REVISION_3_0 && (elf_hwcap & HWCAP_NEON)) {
> + if (mx51_revision() < IMX_CHIP_REVISION_3_0 &&
> + (elf_hwcap & HWCAP_NEON)) {
> elf_hwcap &= ~HWCAP_NEON;
> pr_info("Turning off NEON support, detected broken NEON implementation\n");
> }
Perhaps more readable as:
if (elf_hwcap & HWCAP_NEON &&
mx51_revision() < IMX_CIP_REVISION_3_0) {
elf_hwcap &= ~HWCAP_NEON;
etc...
next prev parent reply other threads:[~2011-11-22 1:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 18:26 [PATCH v2] ARM: mx31pdk: Add MC13783 RTC support Fabio Estevam
2011-11-21 18:26 ` [PATCH] ARM: mx5: Fix checkpatch warnings in cpu-imx5.c Fabio Estevam
2011-11-22 1:24 ` Joe Perches [this message]
2011-11-22 10:35 ` [PATCH v2] ARM: mx31pdk: Add MC13783 RTC support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321925057.1131.2.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox