From: plaes@plaes.org (plaes at plaes.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mach-orion5x: Use hex2bin that is present in kernel lib
Date: Thu, 24 Nov 2011 11:49:33 +0200 [thread overview]
Message-ID: <1322128173.31424.12.camel@localhost.localdomain> (raw)
In-Reply-To: <20111124064018.GD795@wantstofly.org>
?hel kenal p?eval, N, 2011-11-24 kell 07:40, kirjutas Lennert Buytenhek:
> On Wed, Nov 23, 2011 at 04:26:57PM +0200, plaes at plaes.org wrote:
>
[...]
> >
> > [...]
> >
> > for (i = 0; i < 6; i++) {
> > - int byte;
> > -
> > - byte = dns323_parse_hex_byte(mac_page + (i * 3));
> > - if (byte < 0) {
> > + if (hex2bin(addr[i], mac_page + (i * 3), 2))
> > goto error_fail;
>
> I don't think that this does what you think it does...
Indeed. I assume that it didn't even compile. I have fixed the two
issues I found in the previous patch and tweaked the printk output for
TS-x09. Run-tested with similar code on x86 so now I'm confident enough
to sign it off ;)
P?ikest,
Priit Laes ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM-mach-orion5x-Use-hex2bin-that-is-present-in-kern.patch
Type: text/x-patch
Size: 3353 bytes
Desc:
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111124/e786a30b/attachment.bin>
prev parent reply other threads:[~2011-11-24 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 14:26 [PATCH] ARM: mach-orion5x: Use hex2bin that is present in kernel lib plaes at plaes.org
2011-11-24 6:40 ` Lennert Buytenhek
2011-11-24 9:49 ` plaes at plaes.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322128173.31424.12.camel@localhost.localdomain \
--to=plaes@plaes.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox