From: coelho@ti.com (Luciano Coelho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] omap: board-sdp4430: declare support for MMC_PM_KEEP_POWER
Date: Mon, 28 Nov 2011 11:08:44 +0200 [thread overview]
Message-ID: <1322471324.6502.32.camel@cumari> (raw)
In-Reply-To: <CAB3XZEenx7L07BYmrHGt0h9ZAY-LOpWXL+in0vs7XOoeBf_LUw@mail.gmail.com>
On Mon, 2011-11-28 at 10:26 +0200, Eliad Peller wrote:
> On Mon, Nov 28, 2011 at 9:50 AM, Coelho, Luciano <coelho@ti.com> wrote:
> > On Tue, Nov 22, 2011 at 4:02 PM, Eliad Peller <eliad@wizery.com> wrote:
> >> Declare support for keeping the power of the wlan chip
> >> while suspended. this is needed for Wakeup-On-Wireless.
> >>
> >> Signed-off-by: Eliad Peller <eliad@wizery.com>
> >> ---
> >> arch/arm/mach-omap2/board-4430sdp.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > What about all the other board files that also have this structure?
> > For example board-omap4panda.c? I think they should all be changed and
> > the change should also be communicated more broadly for those board
> > files which (unfortunately) are not upstream (or which are upstream
> > but without the wl12xx-specific definitions on it, such as Beagle).
> >
> i preferred adding this capability only for boards i can test.
> unfortunately, i don't a panda/beagle setup.
> anyway, i don't think we have to add it all at once.
> let's just do it one board at a time... i'll add support for zoom as
> well. any volunteers for panda/beagle? ;)
Hmmm, okay, there is logic in that for the pragmatic, but this seems to
be so clearly what is needed to solve the same problem with other boards
that it could deserve changing all the board files. In practice, your
changes may affect all the other boards too, regardless of whether you
set the new flag or not. In any case, not my call here.
I may do it for panda later on, if I get the time to test it. For
beagle, it doesn't really apply, because the wl12xx support is
out-of-tree, unfortunately. :(
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-11-28 9:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 14:02 [PATCH 1/3] omap_hsmmc: consider MMC_PM_KEEP_POWER on suspend/resume Eliad Peller
2011-11-22 14:02 ` [PATCH 2/3] omap_hsmmc: add pm_caps field Eliad Peller
2011-11-28 9:15 ` Igor Grinberg
2011-11-28 9:23 ` Eliad Peller
2011-11-28 10:01 ` Igor Grinberg
2011-11-28 10:07 ` Eliad Peller
2011-11-28 10:39 ` Igor Grinberg
2011-11-22 14:02 ` [PATCH 3/3] omap: board-sdp4430: declare support for MMC_PM_KEEP_POWER Eliad Peller
2011-11-28 7:50 ` Coelho, Luciano
2011-11-28 8:26 ` Eliad Peller
2011-11-28 9:08 ` Luciano Coelho [this message]
2011-11-28 9:26 ` Igor Grinberg
2011-11-28 9:58 ` Luciano Coelho
2011-11-28 10:12 ` Eliad Peller
2011-11-28 10:18 ` Luciano Coelho
2011-12-01 18:16 ` [PATCH 1/3] omap_hsmmc: consider MMC_PM_KEEP_POWER on suspend/resume Chris Ball
2011-12-09 0:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322471324.6502.32.camel@cumari \
--to=coelho@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox