From: tixy@yxit.co.uk (Tixy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kprobes: Change testcase with unpredictable STRD instruction
Date: Thu, 01 Dec 2011 07:33:22 +0000 [thread overview]
Message-ID: <1322724802.2352.0.camel@computer2> (raw)
In-Reply-To: <20111130235644.GY9581@n2100.arm.linux.org.uk>
On Wed, 2011-11-30 at 23:56 +0000, Russell King - ARM Linux wrote:
> On Sun, Nov 27, 2011 at 12:11:25PM +0000, Tixy wrote:
> > There is a kprobes testcase for the instruction "strd r2, [r3], r4".
> > This has unpredictable behaviour as it uses r3 for register writeback
> > addressing and also stores it to memory.
> >
> > On a cortex A9, this testcase would fail because the instruction writes
> > the updated value of r3 to memory, whereas the kprobes emulation code
> > writes the original value.
> >
> > Fix this by changing testcase to used r5 instead of r3.
>
> Is this a -stable candidate?
No, the test code is new in 3.2
--
Tixy
prev parent reply other threads:[~2011-12-01 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 12:11 [PATCH] ARM: kprobes: Change testcase with unpredictable STRD instruction Tixy
2011-11-28 16:29 ` Nicolas Pitre
2011-11-30 23:56 ` Russell King - ARM Linux
2011-12-01 7:33 ` Tixy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322724802.2352.0.camel@computer2 \
--to=tixy@yxit.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox