* [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared
@ 2011-12-01 15:24 Axel Lin
2011-12-01 15:25 ` [PATCH 2/2] ARM: exynos4: Fix build error Axel Lin
2011-12-01 16:39 ` [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Marc Zyngier
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2011-12-01 15:24 UTC (permalink / raw)
To: linux-arm-kernel
Fix below build error:
CC arch/arm/mach-exynos/cpu.o
arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared (first use in this function)
arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is reported only once
arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
make: *** [arch/arm/mach-exynos] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
arch/arm/mach-exynos/cpu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
index fed62f4..c7cb462 100644
--- a/arch/arm/mach-exynos/cpu.c
+++ b/arch/arm/mach-exynos/cpu.c
@@ -240,7 +240,7 @@ static const struct of_device_id exynos4_dt_irq_match[] = {
void __init exynos4_init_irq(void)
{
int irq;
- unsigned int bank_offset;
+ unsigned int gic_bank_offset;
gic_bank_offset = soc_is_exynos4412() ? 0x4000 : 0x8000;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] ARM: exynos4: Fix build error
2011-12-01 15:24 [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Axel Lin
@ 2011-12-01 15:25 ` Axel Lin
2011-12-01 16:39 ` [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Marc Zyngier
1 sibling, 0 replies; 5+ messages in thread
From: Axel Lin @ 2011-12-01 15:25 UTC (permalink / raw)
To: linux-arm-kernel
Trivial fix to fix below build error:
CC arch/arm/mach-exynos/mach-universal_c210.o
arch/arm/mach-exynos/mach-universal_c210.c:24: error: expected identifier or '(' before '<' token
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
arch/arm/mach-exynos/mach-universal_c210.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c
index 48e85b0..cfc7d50 100644
--- a/arch/arm/mach-exynos/mach-universal_c210.c
+++ b/arch/arm/mach-exynos/mach-universal_c210.c
@@ -21,7 +21,7 @@
#include <linux/mmc/host.h>
#include <linux/i2c-gpio.h>
#include <linux/i2c/mcs.h>
- <linux/i2c/atmel_mxt_ts.h>
+#include <linux/i2c/atmel_mxt_ts.h>
#include <asm/mach/arch.h>
#include <asm/hardware/gic.h>
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared
2011-12-01 15:24 [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Axel Lin
2011-12-01 15:25 ` [PATCH 2/2] ARM: exynos4: Fix build error Axel Lin
@ 2011-12-01 16:39 ` Marc Zyngier
2011-12-02 8:43 ` Kukjin Kim
1 sibling, 1 reply; 5+ messages in thread
From: Marc Zyngier @ 2011-12-01 16:39 UTC (permalink / raw)
To: linux-arm-kernel
On 01/12/11 15:24, Axel Lin wrote:
> Fix below build error:
> CC arch/arm/mach-exynos/cpu.o
> arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
> arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared (first use in this function)
> arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is reported only once
> arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
> arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
> make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
> make: *** [arch/arm/mach-exynos] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Arghhh... My bad. Thanks for fixing that.
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/mach-exynos/cpu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
> index fed62f4..c7cb462 100644
> --- a/arch/arm/mach-exynos/cpu.c
> +++ b/arch/arm/mach-exynos/cpu.c
> @@ -240,7 +240,7 @@ static const struct of_device_id exynos4_dt_irq_match[] = {
> void __init exynos4_init_irq(void)
> {
> int irq;
> - unsigned int bank_offset;
> + unsigned int gic_bank_offset;
>
> gic_bank_offset = soc_is_exynos4412() ? 0x4000 : 0x8000;
>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared
2011-12-01 16:39 ` [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Marc Zyngier
@ 2011-12-02 8:43 ` Kukjin Kim
2011-12-02 9:24 ` Marc Zyngier
0 siblings, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2011-12-02 8:43 UTC (permalink / raw)
To: linux-arm-kernel
Marc Zyngier wrote:
>
> On 01/12/11 15:24, Axel Lin wrote:
> > Fix below build error:
> > CC arch/arm/mach-exynos/cpu.o
> > arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
> > arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared
> (first use in this function)
> > arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is
> reported only once
> > arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
> > arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
> > make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
> > make: *** [arch/arm/mach-exynos] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Arghhh... My bad. Thanks for fixing that.
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>
Hi Marc,
Since the commit 4e44d2cb("ARM: exynos4: convert to CONFIG_MULTI_IRQ_HANDLER") is not in my tree, this should be handled in your tree and Axel's patch, "ARM: exynos4: Fix build error" is too.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> > ---
> > arch/arm/mach-exynos/cpu.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
> > index fed62f4..c7cb462 100644
> > --- a/arch/arm/mach-exynos/cpu.c
> > +++ b/arch/arm/mach-exynos/cpu.c
> > @@ -240,7 +240,7 @@ static const struct of_device_id
> exynos4_dt_irq_match[] = {
> > void __init exynos4_init_irq(void)
> > {
> > int irq;
> > - unsigned int bank_offset;
> > + unsigned int gic_bank_offset;
> >
> > gic_bank_offset = soc_is_exynos4412() ? 0x4000 : 0x8000;
> >
>
>
> --
> Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared
2011-12-02 8:43 ` Kukjin Kim
@ 2011-12-02 9:24 ` Marc Zyngier
0 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2011-12-02 9:24 UTC (permalink / raw)
To: linux-arm-kernel
On 02/12/11 08:43, Kukjin Kim wrote:
> Marc Zyngier wrote:
>>
>> On 01/12/11 15:24, Axel Lin wrote:
>>> Fix below build error:
>>> CC arch/arm/mach-exynos/cpu.o
>>> arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
>>> arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared
>> (first use in this function)
>>> arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is
>> reported only once
>>> arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
>>> arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
>>> make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
>>> make: *** [arch/arm/mach-exynos] Error 2
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>>
>> Arghhh... My bad. Thanks for fixing that.
>>
>> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>>
> Hi Marc,
>
> Since the commit 4e44d2cb("ARM: exynos4: convert to CONFIG_MULTI_IRQ_HANDLER") is not in my tree, this should be handled in your tree and Axel's patch, "ARM: exynos4: Fix build error" is too.
Hi Kukjin,
No problem, I'll take these through my tree and send a pull request to
Russell.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-02 9:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-01 15:24 [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Axel Lin
2011-12-01 15:25 ` [PATCH 2/2] ARM: exynos4: Fix build error Axel Lin
2011-12-01 16:39 ` [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Marc Zyngier
2011-12-02 8:43 ` Kukjin Kim
2011-12-02 9:24 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).