From: rob.lee@linaro.org (Robert Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 4/8] ARM: exynos: Replace init with new common ARM cpuidle init code
Date: Mon, 5 Dec 2011 22:38:07 -0600 [thread overview]
Message-ID: <1323146291-10676-5-git-send-email-rob.lee@linaro.org> (raw)
In-Reply-To: <1323146291-10676-1-git-send-email-rob.lee@linaro.org>
Replace duplicated cpuidle init functionality with common ARM cpuidle
init implementation.
Signed-off-by: Robert Lee <rob.lee@linaro.org>
---
arch/arm/mach-exynos/cpuidle.c | 66 +++++++--------------------------------
1 files changed, 12 insertions(+), 54 deletions(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
index 4ebb382..a21b7da 100644
--- a/arch/arm/mach-exynos/cpuidle.c
+++ b/arch/arm/mach-exynos/cpuidle.c
@@ -13,80 +13,38 @@
#include <linux/cpuidle.h>
#include <linux/io.h>
#include <linux/export.h>
-#include <linux/time.h>
-
#include <asm/proc-fns.h>
+#include <asm/cpuidle.h>
-static int exynos4_enter_idle(struct cpuidle_device *dev,
- struct cpuidle_driver *drv,
- int index);
-
-static struct cpuidle_state exynos4_cpuidle_set[] = {
- [0] = {
- .enter = exynos4_enter_idle,
+static struct cpuidle_driver exynos4_idle_driver = {
+ .name = "exynos4_idle",
+ .owner = THIS_MODULE,
+ .states[0] = {
.exit_latency = 1,
.target_residency = 100000,
.flags = CPUIDLE_FLAG_TIME_VALID,
.name = "IDLE",
.desc = "ARM clock gating(WFI)",
},
-};
-
-static DEFINE_PER_CPU(struct cpuidle_device, exynos4_cpuidle_device);
-
-static struct cpuidle_driver exynos4_idle_driver = {
- .name = "exynos4_idle",
- .owner = THIS_MODULE,
+ .state_count = 1,
};
static int exynos4_enter_idle(struct cpuidle_device *dev,
- struct cpuidle_driver *drv,
+ struct cpuidle_driver *drv,
int index)
{
- struct timeval before, after;
- int idle_time;
-
- local_irq_disable();
- do_gettimeofday(&before);
-
cpu_do_idle();
- do_gettimeofday(&after);
- local_irq_enable();
- idle_time = (after.tv_sec - before.tv_sec) * USEC_PER_SEC +
- (after.tv_usec - before.tv_usec);
-
- dev->last_residency = idle_time;
return index;
}
static int __init exynos4_init_cpuidle(void)
{
- int i, max_cpuidle_state, cpu_id;
- struct cpuidle_device *device;
- struct cpuidle_driver *drv = &exynos4_idle_driver;
-
- /* Setup cpuidle driver */
- drv->state_count = (sizeof(exynos4_cpuidle_set) /
- sizeof(struct cpuidle_state));
- max_cpuidle_state = drv->state_count;
- for (i = 0; i < max_cpuidle_state; i++) {
- memcpy(&drv->states[i], &exynos4_cpuidle_set[i],
- sizeof(struct cpuidle_state));
- }
- cpuidle_register_driver(&exynos4_idle_driver);
-
- for_each_cpu(cpu_id, cpu_online_mask) {
- device = &per_cpu(exynos4_cpuidle_device, cpu_id);
- device->cpu = cpu_id;
-
- device->state_count = drv->state_count;
+ int ret;
- if (cpuidle_register_device(device)) {
- printk(KERN_ERR "CPUidle register device failed\n,");
- return -EIO;
- }
- }
- return 0;
+ ret = arm_cpuidle_init(&exynos4_idle_driver,
+ exynos4_enter_idle,
+ NULL);
+ return ret;
}
device_initcall(exynos4_init_cpuidle);
--
1.7.1
next prev parent reply other threads:[~2011-12-06 4:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 4:38 [RFC PATCH 0/8] Add common ARM cpuidle init code Robert Lee
2011-12-06 4:38 ` [RFC PATCH 1/8] ARM: Add commonly used " Robert Lee
2011-12-06 11:47 ` Mark Brown
2011-12-08 17:34 ` Rob Lee
2011-12-09 8:25 ` Mark Brown
2011-12-06 15:06 ` Rob Herring
2011-12-08 21:46 ` Rob Lee
2011-12-09 13:54 ` Rob Herring
2011-12-09 15:55 ` Rob Lee
2011-12-09 19:48 ` Nicolas Pitre
2011-12-06 4:38 ` [RFC PATCH 2/8] ARM: at91: Replace init with new common ARM " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 3/8] ARM: kirkwood: " Robert Lee
2011-12-06 4:38 ` Robert Lee [this message]
2011-12-06 4:38 ` [RFC PATCH 5/8] ARM: davinci: " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 6/8] ARM: shmobile: " Robert Lee
2011-12-06 4:38 ` [RFC PATCH 7/8] ARM: imx: Add mx5 clock changes necessary for low power Robert Lee
2011-12-06 4:38 ` [RFC PATCH 8/8] ARM: imx: Add mx5 cpuidle implmentation Robert Lee
2011-12-08 14:56 ` [RFC PATCH 0/8] Add common ARM cpuidle init code Shawn Guo
2011-12-08 15:37 ` Arnd Bergmann
2012-01-03 14:54 ` Daniel Lezcano
2012-01-03 16:02 ` Arnd Bergmann
2012-01-04 9:17 ` Daniel Lezcano
2012-01-04 18:05 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323146291-10676-5-git-send-email-rob.lee@linaro.org \
--to=rob.lee@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).