* [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path
@ 2011-12-07 2:12 Paul Gortmaker
2011-12-07 3:19 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2011-12-07 2:12 UTC (permalink / raw)
To: linux-arm-kernel
Building defconfigs is a routine operation for people checking
code that touches multiple arch. But this defconfig calls out
a path to a toolchain that most people will never have.
The defconfigs should not be calling out site specific toolchain
locations, so delete the setting of CROSS_COMPILE.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/arch/arm/configs/pcontrol_g20_defconfig b/arch/arm/configs/pcontrol_g20_defconfig
index c75c9fc..4324a77 100644
--- a/arch/arm/configs/pcontrol_g20_defconfig
+++ b/arch/arm/configs/pcontrol_g20_defconfig
@@ -1,5 +1,4 @@
CONFIG_EXPERIMENTAL=y
-CONFIG_CROSS_COMPILE="/opt/arm-2010q1/bin/arm-none-linux-gnueabi-"
# CONFIG_LOCALVERSION_AUTO is not set
# CONFIG_SWAP is not set
CONFIG_SYSVIPC=y
--
1.7.7.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path
2011-12-07 2:12 [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path Paul Gortmaker
@ 2011-12-07 3:19 ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-07 3:26 ` Paul Gortmaker
0 siblings, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-12-07 3:19 UTC (permalink / raw)
To: linux-arm-kernel
On 21:12 Tue 06 Dec , Paul Gortmaker wrote:
> Building defconfigs is a routine operation for people checking
> code that touches multiple arch. But this defconfig calls out
> a path to a toolchain that most people will never have.
>
> The defconfigs should not be calling out site specific toolchain
> locations, so delete the setting of CROSS_COMPILE.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
simply drop this defconfig is not maintain
now we have soc defconfig
Best Regards,
J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path
2011-12-07 3:19 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2011-12-07 3:26 ` Paul Gortmaker
2011-12-07 10:39 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2011-12-07 3:26 UTC (permalink / raw)
To: linux-arm-kernel
[Re: [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path] On 07/12/2011 (Wed 04:19) Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 21:12 Tue 06 Dec , Paul Gortmaker wrote:
> > Building defconfigs is a routine operation for people checking
> > code that touches multiple arch. But this defconfig calls out
> > a path to a toolchain that most people will never have.
> >
> > The defconfigs should not be calling out site specific toolchain
> > locations, so delete the setting of CROSS_COMPILE.
> >
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> simply drop this defconfig is not maintain
Sure, that works too. Do I need to send a delete commit (seems
somewhat pointless) or can I assume someone else will STONITH it?
Thanks,
Paul.
>
> now we have soc defconfig
>
> Best Regards,
> J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path
2011-12-07 3:26 ` Paul Gortmaker
@ 2011-12-07 10:39 ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-08 1:47 ` [PATCH] ARM: delete the pcontrol_g20_defconfig Paul Gortmaker
0 siblings, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-12-07 10:39 UTC (permalink / raw)
To: linux-arm-kernel
On 22:26 Tue 06 Dec , Paul Gortmaker wrote:
> [Re: [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path] On 07/12/2011 (Wed 04:19) Jean-Christophe PLAGNIOL-VILLARD wrote:
>
> > On 21:12 Tue 06 Dec , Paul Gortmaker wrote:
> > > Building defconfigs is a routine operation for people checking
> > > code that touches multiple arch. But this defconfig calls out
> > > a path to a toolchain that most people will never have.
> > >
> > > The defconfigs should not be calling out site specific toolchain
> > > locations, so delete the setting of CROSS_COMPILE.
> > >
> > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > simply drop this defconfig is not maintain
>
> Sure, that works too. Do I need to send a delete commit (seems
> somewhat pointless) or can I assume someone else will STONITH it?
please do so
Best Regards,
J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: delete the pcontrol_g20_defconfig
2011-12-07 10:39 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2011-12-08 1:47 ` Paul Gortmaker
0 siblings, 0 replies; 5+ messages in thread
From: Paul Gortmaker @ 2011-12-08 1:47 UTC (permalink / raw)
To: linux-arm-kernel
In routine testing I found this file should not specify a site
specific toolchain path. I suggested that the defconfigs should
not be calling out site specific toolchain locations, so we should
delete the setting of CROSS_COMPILE. In response, it was indicated
that this is an obsolete defconfig and it should simply be deleted.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
diff --git a/arch/arm/configs/pcontrol_g20_defconfig b/arch/arm/configs/pcontrol_g20_defconfig
deleted file mode 100644
index c75c9fc..0000000
--- a/arch/arm/configs/pcontrol_g20_defconfig
+++ /dev/null
@@ -1,175 +0,0 @@
-CONFIG_EXPERIMENTAL=y
-CONFIG_CROSS_COMPILE="/opt/arm-2010q1/bin/arm-none-linux-gnueabi-"
-# CONFIG_LOCALVERSION_AUTO is not set
-# CONFIG_SWAP is not set
-CONFIG_SYSVIPC=y
-CONFIG_POSIX_MQUEUE=y
-CONFIG_TREE_PREEMPT_RCU=y
-CONFIG_IKCONFIG=y
-CONFIG_IKCONFIG_PROC=y
-CONFIG_LOG_BUF_SHIFT=14
-CONFIG_NAMESPACES=y
-CONFIG_BLK_DEV_INITRD=y
-CONFIG_EXPERT=y
-# CONFIG_SYSCTL_SYSCALL is not set
-# CONFIG_KALLSYMS is not set
-# CONFIG_VM_EVENT_COUNTERS is not set
-# CONFIG_COMPAT_BRK is not set
-CONFIG_SLAB=y
-CONFIG_MODULES=y
-CONFIG_MODULE_UNLOAD=y
-# CONFIG_LBDAF is not set
-# CONFIG_BLK_DEV_BSG is not set
-CONFIG_DEFAULT_DEADLINE=y
-CONFIG_ARCH_AT91=y
-CONFIG_ARCH_AT91SAM9G20=y
-CONFIG_MACH_PCONTROL_G20=y
-CONFIG_AT91_PROGRAMMABLE_CLOCKS=y
-CONFIG_NO_HZ=y
-CONFIG_HIGH_RES_TIMERS=y
-CONFIG_PREEMPT=y
-CONFIG_AEABI=y
-# CONFIG_OABI_COMPAT is not set
-CONFIG_ZBOOT_ROM_TEXT=0x0
-CONFIG_ZBOOT_ROM_BSS=0x0
-CONFIG_CMDLINE="console=ttyS0,115200 mem=128M mtdparts=atmel_nand:128k(bootstrap)ro,256k(uboot)ro,128k(env1)ro,128k(env2)ro,2M(linux),-(root) root=/dev/mmcblk0p1 rootwait rw"
-CONFIG_VFP=y
-CONFIG_BINFMT_MISC=y
-CONFIG_NET=y
-CONFIG_PACKET=y
-CONFIG_UNIX=y
-CONFIG_INET=y
-# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
-# CONFIG_INET_XFRM_MODE_TUNNEL is not set
-# CONFIG_INET_XFRM_MODE_BEET is not set
-# CONFIG_INET_LRO is not set
-# CONFIG_IPV6 is not set
-CONFIG_VLAN_8021Q=y
-# CONFIG_WIRELESS is not set
-CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
-# CONFIG_FW_LOADER is not set
-CONFIG_MTD=y
-CONFIG_MTD_PARTITIONS=y
-CONFIG_MTD_CMDLINE_PARTS=y
-CONFIG_MTD_CHAR=y
-CONFIG_MTD_BLOCK=y
-CONFIG_MTD_COMPLEX_MAPPINGS=y
-CONFIG_MTD_PHRAM=m
-CONFIG_MTD_NAND=y
-CONFIG_MTD_NAND_ATMEL=y
-CONFIG_BLK_DEV_LOOP=y
-CONFIG_BLK_DEV_RAM=y
-CONFIG_BLK_DEV_RAM_SIZE=8192
-CONFIG_ATMEL_TCLIB=y
-CONFIG_EEPROM_AT24=m
-CONFIG_SCSI=m
-# CONFIG_SCSI_PROC_FS is not set
-CONFIG_BLK_DEV_SD=m
-CONFIG_SCSI_MULTI_LUN=y
-# CONFIG_SCSI_LOWLEVEL is not set
-CONFIG_NETDEVICES=y
-CONFIG_MACVLAN=m
-CONFIG_TUN=m
-CONFIG_SMSC_PHY=m
-CONFIG_BROADCOM_PHY=m
-CONFIG_NET_ETHERNET=y
-CONFIG_MII=y
-CONFIG_MACB=y
-CONFIG_SMSC911X=m
-# CONFIG_NETDEV_1000 is not set
-# CONFIG_NETDEV_10000 is not set
-# CONFIG_WLAN is not set
-CONFIG_PPP=m
-CONFIG_PPP_ASYNC=m
-CONFIG_PPP_DEFLATE=m
-CONFIG_PPP_MPPE=m
-CONFIG_INPUT_POLLDEV=y
-CONFIG_INPUT_SPARSEKMAP=y
-# CONFIG_INPUT_MOUSEDEV is not set
-CONFIG_INPUT_EVDEV=m
-CONFIG_INPUT_EVBUG=m
-# CONFIG_KEYBOARD_ATKBD is not set
-CONFIG_KEYBOARD_GPIO=m
-CONFIG_KEYBOARD_MATRIX=m
-# CONFIG_INPUT_MOUSE is not set
-CONFIG_INPUT_TOUCHSCREEN=y
-CONFIG_INPUT_MISC=y
-CONFIG_INPUT_UINPUT=m
-CONFIG_INPUT_GPIO_ROTARY_ENCODER=m
-# CONFIG_SERIO is not set
-# CONFIG_DEVKMEM is not set
-CONFIG_SERIAL_ATMEL=y
-CONFIG_SERIAL_ATMEL_CONSOLE=y
-CONFIG_SERIAL_MAX3100=m
-# CONFIG_LEGACY_PTYS is not set
-# CONFIG_HW_RANDOM is not set
-CONFIG_R3964=m
-CONFIG_I2C=m
-CONFIG_I2C_CHARDEV=m
-# CONFIG_I2C_HELPER_AUTO is not set
-CONFIG_I2C_GPIO=m
-CONFIG_SPI=y
-CONFIG_SPI_ATMEL=m
-CONFIG_SPI_SPIDEV=m
-CONFIG_GPIO_SYSFS=y
-CONFIG_W1=m
-CONFIG_W1_MASTER_GPIO=m
-CONFIG_W1_SLAVE_DS2431=m
-# CONFIG_HWMON is not set
-CONFIG_WATCHDOG=y
-CONFIG_AT91SAM9X_WATCHDOG=y
-# CONFIG_MFD_SUPPORT is not set
-# CONFIG_HID_SUPPORT is not set
-CONFIG_USB=y
-# CONFIG_USB_DEVICE_CLASS is not set
-CONFIG_USB_OHCI_HCD=y
-CONFIG_USB_STORAGE=m
-CONFIG_USB_LIBUSUAL=y
-CONFIG_USB_SERIAL=m
-CONFIG_USB_SERIAL_GENERIC=y
-CONFIG_USB_SERIAL_FTDI_SIO=m
-CONFIG_USB_SERIAL_PL2303=m
-CONFIG_USB_GADGET=y
-CONFIG_USB_ZERO=m
-CONFIG_USB_ETH=m
-CONFIG_USB_FILE_STORAGE=m
-CONFIG_USB_G_SERIAL=m
-CONFIG_USB_G_HID=m
-CONFIG_MMC=y
-CONFIG_MMC_UNSAFE_RESUME=y
-CONFIG_MMC_ATMELMCI=y
-CONFIG_NEW_LEDS=y
-CONFIG_LEDS_CLASS=y
-CONFIG_LEDS_GPIO=y
-CONFIG_LEDS_TRIGGERS=y
-CONFIG_LEDS_TRIGGER_TIMER=y
-CONFIG_LEDS_TRIGGER_HEARTBEAT=y
-CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
-CONFIG_RTC_CLASS=y
-CONFIG_RTC_DRV_AT91SAM9=y
-CONFIG_AUXDISPLAY=y
-CONFIG_UIO=y
-CONFIG_UIO_PDRV=y
-CONFIG_STAGING=y
-# CONFIG_STAGING_EXCLUDE_BUILD is not set
-CONFIG_IIO=y
-CONFIG_EXT2_FS=y
-CONFIG_EXT3_FS=y
-# CONFIG_EXT3_FS_XATTR is not set
-CONFIG_VFAT_FS=y
-CONFIG_TMPFS=y
-CONFIG_JFFS2_FS=y
-CONFIG_NFS_FS=y
-CONFIG_NFS_V3=y
-CONFIG_NFS_V4=y
-CONFIG_PARTITION_ADVANCED=y
-CONFIG_NLS_CODEPAGE_437=y
-CONFIG_NLS_CODEPAGE_850=y
-CONFIG_NLS_ISO8859_1=y
-CONFIG_NLS_ISO8859_15=y
-CONFIG_NLS_UTF8=y
-# CONFIG_RCU_CPU_STALL_DETECTOR is not set
-CONFIG_CRYPTO=y
-CONFIG_CRYPTO_ANSI_CPRNG=y
-# CONFIG_CRYPTO_HW is not set
-CONFIG_CRC_CCITT=y
--
1.7.7.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-08 1:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-07 2:12 [PATCH] ARM: pcontrol_g20_defconfig should not specify toolchain path Paul Gortmaker
2011-12-07 3:19 ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-07 3:26 ` Paul Gortmaker
2011-12-07 10:39 ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-08 1:47 ` [PATCH] ARM: delete the pcontrol_g20_defconfig Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).