From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 resend2] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver use gpiolib
Date: Tue, 13 Dec 2011 14:16:51 -0800 [thread overview]
Message-ID: <1323814611.3837.40.camel@joe2Laptop> (raw)
In-Reply-To: <4EE7CC34.8000209@solonet.org.ua>
On Wed, 2011-12-14 at 00:05 +0200, Denis Kuzmenko wrote:
> On 12/13/2011 11:40 PM, Joe Perches wrote:
> > On Tue, 2011-12-13 at 23:33 +0200, Denis Kuzmenko wrote:
> >> On 12/13/2011 11:28 PM, Joe Perches wrote:
> >>> The LEDF_ACTLOW use is dependent on it being #defined
> >>> to 1 when using ^. I think that's unintelligible.
> >> Sorry, can't understand. Can you please clarify last two sentences?
> > s3c2410_gpio_setpin(pd->gpio, (value ? 1 : 0) ^
> > (pd->flags & S3C24XX_LEDF_ACTLOW));
> > I think this should be:
> > s3c2410_gpio_setpin(pd->gpio,
> > !!value ^ !!(pd->flags & S3C24XX_LEDF_ACTLOW));
> So you've found a BUG.
It's not really a bug, it's more lack of consistency
style defect. It's also an example of why I prefer
consistent style to equivalent but different styles.
> As I understand my code will behave wrong if
> S3C24XX_LEDF_ACTLOW value will be changed.
> Thank you, I'll make a new version.
cheers, Joe
prev parent reply other threads:[~2011-12-13 22:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 20:22 [PATCH v3 resend2] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver use gpiolib Denis Kuzmenko
2011-12-13 21:06 ` Joe Perches
2011-12-13 21:21 ` Denis Kuzmenko
2011-12-13 21:28 ` Joe Perches
2011-12-13 21:33 ` Denis Kuzmenko
2011-12-13 21:40 ` Joe Perches
2011-12-13 22:05 ` Denis Kuzmenko
2011-12-13 22:16 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323814611.3837.40.camel@joe2Laptop \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).