* [linux-next] make s5p64x0_defconfig build error
2011-12-14 19:12 ` Russell King - ARM Linux
@ 2011-12-14 20:45 ` Nicolas Pitre
2011-12-14 23:30 ` Denis Kuzmenko
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Nicolas Pitre @ 2011-12-14 20:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 14 Dec 2011, Russell King - ARM Linux wrote:
> On Wed, Dec 14, 2011 at 12:32:44PM +0000, Will Deacon wrote:
> > On Wed, Dec 14, 2011 at 04:57:10AM +0000, Axel Lin wrote:
> > > I got below build error on linux-next 20111213.
> > >
> > > CC arch/arm/kernel/process.o
> > > In file included from arch/arm/mach-s5p64x0/include/mach/system.h:16,
> > > from arch/arm/kernel/process.c:64:
> > > arch/arm/plat-samsung/include/plat/system-reset.h:19:2: error: #error Fix me up
> > > make[1]: *** [arch/arm/kernel/process.o] Error 1
> > > make: *** [arch/arm/kernel] Error 2
> >
> > The clue is in the commit message:
> >
> > commit d0f7e2beabe6a116152ccc31959b6654b6ef0071
> > Author: Russell King <rmk+kernel@arm.linux.org.uk>
> > Date: Tue Dec 6 12:57:02 2011 +0000
> >
> > ARM: restart: Temporary #error to persuade platform maintainers to take the restart changes seriously
> >
> > Force builds to fail to ensure that platform maintainers take the
> > restart changes seriously, and sort out fixing their code before the
> > next merge window.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Indeed, and note the date, and how long its taken for just one of the
> platforms to be noticed.
>
> It seems to me that no one really cares about whether six of the seven
> platforms which have the #error build or don't build, so I really think
> there's a simple solution to this at the next merge window - delete any
> platform which hasn't _at_ _least_ responded with a proposed patch to
> this.
>
> The platform maintainers have had _enough_ notice of this - by not
> responding, they're quite simply an obstacle to further consolidation,
> and we're not going to go through months of waiting for their response
> time and time again.
>
> I've posted the patches to the mailing list, I've copied them asking
> for help, I've chased them several times, and now they have a #error
> to deal with. If none of this gets their attention (it seems it
> doesn't), then frankly their platform is unmaintained, it will be
> broken at the next merge window, and therefore _should_ be deleted.
>
> So... unless things change, we can expect Gemini, almost all Samsung
> stuff, shmobile, vt8500, and Telechips TCC8k to be at least broken at
> the next merge window.
Let me add to this by pointing to this piece of code in
arch/arm/include/asm/pgtable.h:
|/* This is a temporary hack until shmobile's DMA area size is sorted out */
|#ifdef CONFIG_ARCH_SHMOBILE
|#warning "SH-Mobile's consistent DMA size conflicts with VMALLOC_END by 144MB"
|#undef VMALLOC_END
|#define VMALLOC_END 0xF6000000UL
|#endif
Again, the reason for this is in the commit message. My hope was that,
by the central nature of this header file, the build would be
sufficiently overwhelmed with #warning noise that the maintainers would
manifest themselves and come forth with the needed fix.
After repeated inquiries to the listed maintainers in the MAINTAINERS
file, I still didn't receive any feedback at this point, and I still
can't find a reason for the current state of things either by looking at
the concerned code or the related Git commit logs.
So if no one cares about this platform then I propose to delete it for
v3.3 as well.
Nicolas
^ permalink raw reply [flat|nested] 10+ messages in thread* [linux-next] make s5p64x0_defconfig build error
2011-12-14 19:12 ` Russell King - ARM Linux
2011-12-14 20:45 ` Nicolas Pitre
@ 2011-12-14 23:30 ` Denis Kuzmenko
2011-12-14 23:54 ` Russell King - ARM Linux
2011-12-14 23:33 ` Kukjin Kim
2011-12-15 5:00 ` Mark Brown
3 siblings, 1 reply; 10+ messages in thread
From: Denis Kuzmenko @ 2011-12-14 23:30 UTC (permalink / raw)
To: linux-arm-kernel
On 12/14/2011 09:12 PM, Russell King - ARM Linux wrote:
> On Wed, Dec 14, 2011 at 12:32:44PM +0000, Will Deacon wrote:
>> On Wed, Dec 14, 2011 at 04:57:10AM +0000, Axel Lin wrote:
> So... unless things change, we can expect Gemini, almost all Samsung
> stuff, shmobile, vt8500, and Telechips TCC8k to be at least broken at
> the next merge window.
Mini2440 march (s3c24xx platform) is not broken in v3.2-rc5. Does that
mean that s3c24xx is untouched by this issue or this means that I should
use linux-next?
If this problem is related to s3c24xx I'm ready to do my best for saving
that platform from being removed.
--
Best regards, Denis Kuzmenko.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-next] make s5p64x0_defconfig build error
2011-12-14 23:30 ` Denis Kuzmenko
@ 2011-12-14 23:54 ` Russell King - ARM Linux
0 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux @ 2011-12-14 23:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 15, 2011 at 01:30:13AM +0200, Denis Kuzmenko wrote:
> On 12/14/2011 09:12 PM, Russell King - ARM Linux wrote:
> > On Wed, Dec 14, 2011 at 12:32:44PM +0000, Will Deacon wrote:
> >> On Wed, Dec 14, 2011 at 04:57:10AM +0000, Axel Lin wrote:
> > So... unless things change, we can expect Gemini, almost all Samsung
> > stuff, shmobile, vt8500, and Telechips TCC8k to be at least broken at
> > the next merge window.
>
> Mini2440 march (s3c24xx platform) is not broken in v3.2-rc5. Does that
> mean that s3c24xx is untouched by this issue or this means that I should
> use linux-next?
Most of the completed changes are in linux-next for the restart changes.
I have some additional commits (which were posted to the list as the 3rd
sub-series), which I'm not planning to submit in their current form -
they move things _towards_ sorting out the samsung stuff, but they're
all incomplete. These continue to be a part of my 'reset' branch.
Basically, the comments in the commit summary line marked with XXX need
addressing - and folk need to get out of the habbit of thinking "it's
an include file, it must go into somewhere called 'include'." Instead,
put includes local to a set of files in a directory in that same
directory.
Author: Russell King <rmk+kernel@arm.linux.org.uk>
Date: Sun Nov 6 16:22:23 2011 +0000
ARM: restart: plat-samsung: remove plat/reset.h and s5p_reset_hook
Now that s5p_reset_hook is unused, we can get rid of plat/reset.h and
the s5p_reset_hook code in plat/system-reset.h.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Author: Russell King <rmk+kernel@arm.linux.org.uk>
Date: Sun Nov 6 16:20:11 2011 +0000
ARM: restart: s5pv210: use new restart hook XXX WIP XXX WHY IS THERE NO LOCAL HEADERS IN arch/arm/mach-exynos4 XXX
Hook these platforms restart code into the new restart hook rather
than using arch_reset().
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Author: Russell King <rmk+kernel@arm.linux.org.uk>
Date: Sun Nov 6 13:24:20 2011 +0000
ARM: restart: exynos4: use new restart hook XXX WIP XXX WHY IS THERE NO LOCAL HEADERS IN arch/arm/mach-exynos4 XXX
Hook these platforms restart code into the new restart hook rather
than using arch_reset().
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-next] make s5p64x0_defconfig build error
2011-12-14 19:12 ` Russell King - ARM Linux
2011-12-14 20:45 ` Nicolas Pitre
2011-12-14 23:30 ` Denis Kuzmenko
@ 2011-12-14 23:33 ` Kukjin Kim
2011-12-14 23:54 ` Axel Lin
2011-12-15 5:00 ` Mark Brown
3 siblings, 1 reply; 10+ messages in thread
From: Kukjin Kim @ 2011-12-14 23:33 UTC (permalink / raw)
To: linux-arm-kernel
Russell King - ARM Linux wrote:
>
> On Wed, Dec 14, 2011 at 12:32:44PM +0000, Will Deacon wrote:
> > On Wed, Dec 14, 2011 at 04:57:10AM +0000, Axel Lin wrote:
> > > I got below build error on linux-next 20111213.
> > >
> > > CC arch/arm/kernel/process.o
> > > In file included from arch/arm/mach-s5p64x0/include/mach/system.h:16,
> > > from arch/arm/kernel/process.c:64:
> > > arch/arm/plat-samsung/include/plat/system-reset.h:19:2: error: #error
> Fix me up
> > > make[1]: *** [arch/arm/kernel/process.o] Error 1
> > > make: *** [arch/arm/kernel] Error 2
> >
> > The clue is in the commit message:
> >
> > commit d0f7e2beabe6a116152ccc31959b6654b6ef0071
> > Author: Russell King <rmk+kernel@arm.linux.org.uk>
> > Date: Tue Dec 6 12:57:02 2011 +0000
> >
> > ARM: restart: Temporary #error to persuade platform maintainers to
> take the restart changes seriously
> >
> > Force builds to fail to ensure that platform maintainers take the
> > restart changes seriously, and sort out fixing their code before the
> > next merge window.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Indeed, and note the date, and how long its taken for just one of the
> platforms to be noticed.
>
> It seems to me that no one really cares about whether six of the seven
> platforms which have the #error build or don't build, so I really think
> there's a simple solution to this at the next merge window - delete any
> platform which hasn't _at_ _least_ responded with a proposed patch to
> this.
>
> The platform maintainers have had _enough_ notice of this - by not
> responding, they're quite simply an obstacle to further consolidation,
> and we're not going to go through months of waiting for their response
> time and time again.
>
> I've posted the patches to the mailing list, I've copied them asking
> for help, I've chased them several times, and now they have a #error
> to deal with. If none of this gets their attention (it seems it
> doesn't), then frankly their platform is unmaintained, it will be
> broken at the next merge window, and therefore _should_ be deleted.
>
> So... unless things change, we can expect Gemini, almost all Samsung
> stuff, shmobile, vt8500, and Telechips TCC8k to be at least broken at
> the next merge window.
Axel and Will, thanks for pointing out.
Oops, I couldn't have much time to follow up :(
But let me look at that in this weekend and I know, it can be escaped before
merge window :)
Anyway, sorry for noisy.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-next] make s5p64x0_defconfig build error
2011-12-14 23:33 ` Kukjin Kim
@ 2011-12-14 23:54 ` Axel Lin
2011-12-15 8:09 ` Heiko Stübner
0 siblings, 1 reply; 10+ messages in thread
From: Axel Lin @ 2011-12-14 23:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kukjin,
> Axel and Will, thanks for pointing out.
>
> Oops, I couldn't have much time to follow up :(
> But let me look at that in this weekend and I know, it can be escaped before
> merge window :)
I also found the same build errors by:
make s5pc100_defconfig
make s5pv210_defconfig
make exynos4_defconfig
Regards,
Axel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-next] make s5p64x0_defconfig build error
2011-12-14 23:54 ` Axel Lin
@ 2011-12-15 8:09 ` Heiko Stübner
0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stübner @ 2011-12-15 8:09 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, 15. Dezember 2011, 00:54:58 schrieb Axel Lin:
> Hi Kukjin,
>
> > Axel and Will, thanks for pointing out.
> >
> > Oops, I couldn't have much time to follow up :(
> > But let me look at that in this weekend and I know, it can be escaped
> > before merge window :)
>
> I also found the same build errors by:
> make s5pc100_defconfig
> make s5pv210_defconfig
> make exynos4_defconfig
make s3c2410_defconfig
also produces the build errors
Heiko
^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-next] make s5p64x0_defconfig build error
2011-12-14 19:12 ` Russell King - ARM Linux
` (2 preceding siblings ...)
2011-12-14 23:33 ` Kukjin Kim
@ 2011-12-15 5:00 ` Mark Brown
3 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-12-15 5:00 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 14, 2011 at 07:12:05PM +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 14, 2011 at 12:32:44PM +0000, Will Deacon wrote:
> > ARM: restart: Temporary #error to persuade platform maintainers to take the restart changes seriously
> > Force builds to fail to ensure that platform maintainers take the
> > restart changes seriously, and sort out fixing their code before the
> > next merge window.
> Indeed, and note the date, and how long its taken for just one of the
> platforms to be noticed.
I noticed s3c64xx the day you added that change but just deleted the
code so I could carry on working after my initial attempts to figure out
what this was about took too long.
> It seems to me that no one really cares about whether six of the seven
> platforms which have the #error build or don't build, so I really think
> there's a simple solution to this at the next merge window - delete any
> platform which hasn't _at_ _least_ responded with a proposed patch to
> this.
Do you have any references to this stuff? I did make some effort to
understand what needed to be done but the patch doesn't mention which
restart changes are needed and my grovelling around in git wasn't
turning up enough context to tell me what was supposed to be happening
instead. Frankly I've no need for that code in my systems so if it's a
problem I'd just throw the restart code away if it was that or breakage.
^ permalink raw reply [flat|nested] 10+ messages in thread