linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ohad@wizery.com (Ohad Ben-Cohen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] remoteproc: do not require an iommu
Date: Wed, 14 Dec 2011 13:48:29 +0200	[thread overview]
Message-ID: <1323863315-8159-2-git-send-email-ohad@wizery.com> (raw)
In-Reply-To: <1323863315-8159-1-git-send-email-ohad@wizery.com>

From: Mark Grosen <mgrosen@ti.com>

Not all remote processors employ an IOMMU, so do not error out
on !iommu_present().

Note: we currently still use iommu_present() to tell whether we need
to configure an IOMMU or not. That works for simple cases, but will
easily fail with more complicated ones (e.g. where an IOMMU exists,
but not all remote processors use it). When those use cases show up,
we will solve them by introducing something like remoteproc hw
capabilities.

[ohad at wizery.com: write commit log]

Signed-off-by: Mark Grosen <mgrosen@ti.com>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
---
 drivers/remoteproc/remoteproc_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index ad93d7d..0d9a955 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -105,8 +105,8 @@ static int rproc_enable_iommu(struct rproc *rproc)
 	 * that will be set by the remoteproc driver.
 	 */
 	if (!iommu_present(dev->bus)) {
-		dev_err(dev, "iommu not found\n");
-		return -ENODEV;
+		dev_dbg(dev, "iommu not found\n");
+		return 0;
 	}
 
 	domain = iommu_domain_alloc(dev->bus);
-- 
1.7.5.4

  reply	other threads:[~2011-12-14 11:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 11:48 [PATCH 0/7] remoteproc/rpmsg: a few trivial fixes Ohad Ben-Cohen
2011-12-14 11:48 ` Ohad Ben-Cohen [this message]
2011-12-14 11:48 ` [PATCH 2/7] remoteproc: avoid registering a virtio device if not supported Ohad Ben-Cohen
2011-12-14 11:48 ` [PATCH 3/7] remoteproc: remove unused resource type Ohad Ben-Cohen
2011-12-14 11:48 ` [PATCH 4/7] remoteproc/omap: utilize module_platform_driver Ohad Ben-Cohen
2011-12-14 11:48 ` [PATCH 5/7] remoteproc: look for truncated firmware images Ohad Ben-Cohen
2011-12-14 11:48 ` [PATCH 6/7] remoteproc: add Kconfig menu Ohad Ben-Cohen
2011-12-14 11:48 ` [PATCH 7/7] rpmsg: " Ohad Ben-Cohen
2011-12-21 11:29 ` [PATCH 0/7] remoteproc/rpmsg: a few trivial fixes Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323863315-8159-2-git-send-email-ohad@wizery.com \
    --to=ohad@wizery.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).