From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2667C433EF for ; Fri, 10 Jun 2022 12:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/BTy9cLV3wBLASt1sz8Eet5kWXEEzi8LJDd2fFqxULU=; b=fh8vm0J90y8Iak 2h4TWXKcQhxkGMzrNtP3DmG3wSy4rrt6z/ibcux32+i7Z5IzWgsMa9Ujq0R+FPuHmYuzLqgnyuYkg hZrd23Ue2OLRP+5QuUOccBTPIGdtMg/ylmmsZ1AySvpok3c9EJsm/GZe0Ms9+mSL0AzKTGHAFwztM mxwXYROpJ/SGb9V3a2oPDYUKaTYac14ymd2+Z4bdLjor90l/XrBNM2ApUhqsgOFQDFdMlY4DiIrkv IY+DAFuY4LgDaH5tR5BAFfgtJ201qk4nAWfvlBIaAjn4wrDaFIpKI8nmOuIS0UYeuQQFsuSk13NtM h+3nd/4YHGZ4WZc6IFtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nze65-008EgG-SD; Fri, 10 Jun 2022 12:50:41 +0000 Received: from dnyon.com ([2a01:4f8:1c1c:1e07::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nze62-008EfU-74 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 12:50:39 +0000 Received: from localhost (localhost [127.0.0.1]) by dnyon.com (Postfix) with ESMTP id C66D15F2B5; Fri, 10 Jun 2022 12:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=dnyon.com; s=mail; t=1654865423; bh=flH/0+64HwAQ7lE3Z5vuJ6QNCOk21fe4t375+QFJE8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xucxv35rTLY2+LZapa8yH04nSBk4XqD2xEg83VUFzooLacQ8umX/SXfiEoafyWTJl xYpH+k7USc+PGC13nXhFMiItm9k3LOnLCNfh9hq/OmOlyDMomkVFHciL+Bsx4i0dDy 2Fv5ynDmCT1y0798837PcW1HGgnI7Twq1tLKWXcRs/Z9bNcJTr9QW5OhH5rU/ediYT VZ7HuDpQ/u1Fk204KRlOK8Vfn4F9RUxZVmwautpukOOSLSAVWvHtGIYRLAx/FtBS5m topGZVhvu3GAFlw+gU2p3+B1/fCh41Beirns1XObYbU2FVsOsYhuEXujOjUL+jzeJh lDOztlVUNXiDw== Received: from dnyon.com by localhost (amavisd-new, unix socket) with LMTP id rKwCbj4m4o9f; Fri, 10 Jun 2022 12:50:23 +0000 (UTC) Received: from dnyon.com (43.red-88-5-137.dynamicip.rima-tde.net [88.5.137.43]) by dnyon.com (Postfix) with ESMTPSA id 904615F2B4; Fri, 10 Jun 2022 12:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=dnyon.com; s=mail; t=1654865423; bh=flH/0+64HwAQ7lE3Z5vuJ6QNCOk21fe4t375+QFJE8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xucxv35rTLY2+LZapa8yH04nSBk4XqD2xEg83VUFzooLacQ8umX/SXfiEoafyWTJl xYpH+k7USc+PGC13nXhFMiItm9k3LOnLCNfh9hq/OmOlyDMomkVFHciL+Bsx4i0dDy 2Fv5ynDmCT1y0798837PcW1HGgnI7Twq1tLKWXcRs/Z9bNcJTr9QW5OhH5rU/ediYT VZ7HuDpQ/u1Fk204KRlOK8Vfn4F9RUxZVmwautpukOOSLSAVWvHtGIYRLAx/FtBS5m topGZVhvu3GAFlw+gU2p3+B1/fCh41Beirns1XObYbU2FVsOsYhuEXujOjUL+jzeJh lDOztlVUNXiDw== From: "Alejandro T." To: Mark Brown Cc: Catalin Marinas , Will Deacon , ~postmarketos/upstreaming@lists.sr.ht, Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/sysreg: Fix typo in Enum element regex Date: Fri, 10 Jun 2022 14:50:18 +0200 Message-ID: <13240249.uLZWGnKmhe@alexbook> In-Reply-To: References: <20220609204220.12112-1-atafalla@dnyon.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_055038_437562_09FB9D6B X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On viernes, 10 de junio de 2022 13:19:50 (CEST) Mark Brown wrote: > On Fri, Jun 10, 2022 at 10:15:04AM +0100, Catalin Marinas wrote: > > On Thu, Jun 09, 2022 at 10:42:18PM +0200, Alejandro Tafalla wrote: > > > In the awk script, there was a typo with the comparison operator when > > > checking if the matched pattern is inside an Enum block. > > > This prevented the generation of the whole sysreg-defs.h header. > > > > > > -/0b[01]+/ && block = "Enum" { > > > +/0b[01]+/ && block == "Enum" { > > > > This makes sense but I'm surprised that we haven't noticed it until now > > (maybe some awk versions treat it as a relational operator). > > What Catlain said - if we weren't generating the full header contents > I'd expect things to fail to build normally, but it's entirely possible > this is just happening to work with some implementations and the patch > is clearly correct. > > Reviewed-by: Mark Brown Hi Mark, thanks for your review. Indeed, I'm building the kernel in Alpine, which uses Busybox instead of gawk. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel