linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: fabio.estevam@freescale.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] usb: gadget: Fix build error due to selection of USB_FSL_MPH_DR_OF by ARCH_MXC
Date: Thu, 22 Dec 2011 09:33:22 -0200	[thread overview]
Message-ID: <1324553602-3411-1-git-send-email-fabio.estevam@freescale.com> (raw)
In-Reply-To: <1324492640-25481-1-git-send-email-fabio.estevam@freescale.com>

USB_FSL_MPH_DR_OF is a PowerPC driver and should not be selected by ARCH_MXC.

Doing a 'make mx3_defconfig' and selecting i.MX6 we get:

CC [M]  drivers/usb/host/fsl-mph-dr-of.o
drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'

Fix this error by not allowing USB_FSL_MPH_DR_OF to be selected by ARCH_MXC.

Cc: stable at kernel.org
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Changed the selection logic to depend on FSL_SOC
- Cc stable at kernel.org

 drivers/usb/gadget/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 23a4473..0148676 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -159,7 +159,7 @@ config USB_FSL_USB2
 	tristate "Freescale Highspeed USB DR Peripheral Controller"
 	depends on FSL_SOC || ARCH_MXC
 	select USB_GADGET_DUALSPEED
-	select USB_FSL_MPH_DR_OF if OF
+	select USB_FSL_MPH_DR_OF if OF && FSL_SOC
 	help
 	   Some of Freescale PowerPC processors have a High Speed
 	   Dual-Role(DR) USB controller, which supports device mode.
-- 
1.7.1

  parent reply	other threads:[~2011-12-22 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 18:37 [PATCH] usb: gadget: Fix build error due to selection of USB_FSL_MPH_DR_OF by ARCH_MXC Fabio Estevam
2011-12-22  6:53 ` Lothar Waßmann
2011-12-22 11:33 ` Fabio Estevam [this message]
2011-12-29 23:26   ` [PATCH v2] " Fabio Estevam
2011-12-30 10:32     ` Felipe Balbi
2012-01-17 20:41       ` Fabio Estevam
2012-01-24  8:25   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324553602-3411-1-git-send-email-fabio.estevam@freescale.com \
    --to=fabio.estevam@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).