linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode
@ 2011-12-26 10:58 Mark Brown
  2011-12-29  3:31 ` Kukjin Kim
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-12-26 10:58 UTC (permalink / raw)
  To: linux-arm-kernel

Entering and leaving WFI is really cheap so there's no reason to have much
of a residency requirement for the state. Lower it to 1ms.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 arch/arm/mach-s3c64xx/cpuidle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/cpuidle.c b/arch/arm/mach-s3c64xx/cpuidle.c
index 625d2c7..179460f 100644
--- a/arch/arm/mach-s3c64xx/cpuidle.c
+++ b/arch/arm/mach-s3c64xx/cpuidle.c
@@ -55,7 +55,7 @@ static struct cpuidle_state s3c64xx_cpuidle_set[] = {
 	[0] = {
 		.enter			= s3c64xx_enter_idle,
 		.exit_latency		= 1,
-		.target_residency	= 100000,
+		.target_residency	= 1,
 		.flags			= CPUIDLE_FLAG_TIME_VALID,
 		.name			= "IDLE",
 		.desc			= "System active, ARM gated",
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode
  2011-12-26 10:58 [PATCH] ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode Mark Brown
@ 2011-12-29  3:31 ` Kukjin Kim
  2011-12-29 10:31   ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Kukjin Kim @ 2011-12-29  3:31 UTC (permalink / raw)
  To: linux-arm-kernel

Mark Brown wrote:
> 
> Entering and leaving WFI is really cheap so there's no reason to have much
> of a residency requirement for the state. Lower it to 1ms.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  arch/arm/mach-s3c64xx/cpuidle.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/cpuidle.c b/arch/arm/mach-
> s3c64xx/cpuidle.c
> index 625d2c7..179460f 100644
> --- a/arch/arm/mach-s3c64xx/cpuidle.c
> +++ b/arch/arm/mach-s3c64xx/cpuidle.c
> @@ -55,7 +55,7 @@ static struct cpuidle_state s3c64xx_cpuidle_set[] = {
>  	[0] = {
>  		.enter			= s3c64xx_enter_idle,
>  		.exit_latency		= 1,
> -		.target_residency	= 100000,
> +		.target_residency	= 1,
>  		.flags			= CPUIDLE_FLAG_TIME_VALID,
>  		.name			= "IDLE",
>  		.desc			= "System active, ARM gated",
> --
> 1.7.7.3

OK, will apply.
Mark, do you want to send this before v3.2?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode
  2011-12-29  3:31 ` Kukjin Kim
@ 2011-12-29 10:31   ` Mark Brown
  2011-12-30  1:51     ` Kukjin Kim
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-12-29 10:31 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 29, 2011 at 12:31:58PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:

> > Entering and leaving WFI is really cheap so there's no reason to have much
> > of a residency requirement for the state. Lower it to 1ms.

> > -		.target_residency	= 100000,
> > +		.target_residency	= 1,

> OK, will apply.
> Mark, do you want to send this before v3.2?

It doesn't seem super urgent, though it'd be nice to get it into 3.3
with the original patch adding the support.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode
  2011-12-29 10:31   ` Mark Brown
@ 2011-12-30  1:51     ` Kukjin Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2011-12-30  1:51 UTC (permalink / raw)
  To: linux-arm-kernel

Mark Brown wrote:
> 
> On Thu, Dec 29, 2011 at 12:31:58PM +0900, Kukjin Kim wrote:
> > Mark Brown wrote:
> 
> > > Entering and leaving WFI is really cheap so there's no reason to have
> much
> > > of a residency requirement for the state. Lower it to 1ms.
> 
> > > -		.target_residency	= 100000,
> > > +		.target_residency	= 1,
> 
> > OK, will apply.
> > Mark, do you want to send this before v3.2?
> 
> It doesn't seem super urgent, though it'd be nice to get it into 3.3
> with the original patch adding the support.

Ah, OK, I've applied this with that.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-12-30  1:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-26 10:58 [PATCH] ARM: S3C64XX: Reduce residency requirement for cpuidle WFI mode Mark Brown
2011-12-29  3:31 ` Kukjin Kim
2011-12-29 10:31   ` Mark Brown
2011-12-30  1:51     ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).