* [PATCH] ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore
@ 2011-12-29 1:26 Mark Brown
2011-12-29 3:36 ` Kukjin Kim
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-12-29 1:26 UTC (permalink / raw)
To: linux-arm-kernel
0 is a valid IRQ but the interrupt line for the pca935x certainly isn't
connected there which causes it to fail to probe.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
arch/arm/mach-s3c64xx/mach-crag6410.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c
index 46dfb14..139d16e 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
@@ -357,7 +357,7 @@ static struct platform_device *crag6410_devices[] __initdata = {
static struct pca953x_platform_data crag6410_pca_data = {
.gpio_base = PCA935X_GPIO_BASE,
- .irq_base = 0,
+ .irq_base = -1,
};
/* VDDARM is controlled by DVS1 connected to GPK(0) */
--
1.7.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore
2011-12-29 1:26 [PATCH] ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore Mark Brown
@ 2011-12-29 3:36 ` Kukjin Kim
2011-12-29 10:32 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Kukjin Kim @ 2011-12-29 3:36 UTC (permalink / raw)
To: linux-arm-kernel
Mark Brown wrote:
>
> 0 is a valid IRQ but the interrupt line for the pca935x certainly isn't
> connected there which causes it to fail to probe.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> arch/arm/mach-s3c64xx/mach-crag6410.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-
> s3c64xx/mach-crag6410.c
> index 46dfb14..139d16e 100644
> --- a/arch/arm/mach-s3c64xx/mach-crag6410.c
> +++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
> @@ -357,7 +357,7 @@ static struct platform_device *crag6410_devices[]
> __initdata = {
>
> static struct pca953x_platform_data crag6410_pca_data = {
> .gpio_base = PCA935X_GPIO_BASE,
> - .irq_base = 0,
> + .irq_base = -1,
> };
>
> /* VDDARM is controlled by DVS1 connected to GPK(0) */
> --
> 1.7.7.3
OK, so do you want to apply this before v3.2?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore
2011-12-29 3:36 ` Kukjin Kim
@ 2011-12-29 10:32 ` Mark Brown
2011-12-30 1:51 ` Kukjin Kim
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-12-29 10:32 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 29, 2011 at 12:36:31PM +0900, Kukjin Kim wrote:
> OK, so do you want to apply this before v3.2?
The problem is mostly cosmetic as the chip isn't actually used by
current cosmetics so no need to try to get it into 3.2.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore
2011-12-29 10:32 ` Mark Brown
@ 2011-12-30 1:51 ` Kukjin Kim
0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2011-12-30 1:51 UTC (permalink / raw)
To: linux-arm-kernel
Mark Brown wrote:
>
> On Thu, Dec 29, 2011 at 12:36:31PM +0900, Kukjin Kim wrote:
>
> > OK, so do you want to apply this before v3.2?
>
> The problem is mostly cosmetic as the chip isn't actually used by
> current cosmetics so no need to try to get it into 3.2.
OK, I see.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-30 1:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-29 1:26 [PATCH] ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore Mark Brown
2011-12-29 3:36 ` Kukjin Kim
2011-12-29 10:32 ` Mark Brown
2011-12-30 1:51 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).