linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ben@decadent.org.uk (Ben Hutchings)
To: linux-arm-kernel@lists.infradead.org
Subject: Circular dependency between <linux/kernel.h> and <asm/bug.h> on ARM
Date: Mon, 02 Jan 2012 02:44:36 +0000	[thread overview]
Message-ID: <1325472276.13595.200.camel@deadeye> (raw)

Commit 87e040b6456fd3416a1f6831c1eedaef5c0a94ff ("ARM: 7017/1: Use
generic BUG() handler") makes BUG() use BUILD_BUG_ON().  However,
BUILD_BUG_ON() is not defined in <linux/bug.h> but in <linux/kernel.h>.

arch/include/asm/bug.h does not include <linux/kernel.h> and *cannot* do
so because the latter already includes <asm/bug.h>.

Maybe BUILD_BUG_ON() should be moved out to a header of its own, or else
this particular use should be moved to some other file.  This needs to
be fixed somehow, as it obviously leads to build failures, e.g.:

https://buildd.debian.org/status/fetch.php?pkg=linux-2.6&arch=armel&ver=3.2~rc7-1~experimental.1&stamp=1325142904

Ben.

-- 
Ben Hutchings
All the simple programs have been written, and all the good names taken.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120102/df7dcba0/attachment.sig>

             reply	other threads:[~2012-01-02  2:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02  2:44 Ben Hutchings [this message]
2012-01-02  7:01 ` Circular dependency between <linux/kernel.h> and <asm/bug.h> on ARM Olof Johansson
2012-01-02 18:54   ` Simon Glass
2012-01-03 14:45   ` Russell King - ARM Linux
2012-01-03 18:33     ` Simon Glass
2012-01-05  3:43     ` Paul Gortmaker
2012-01-06  4:12       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325472276.13595.200.camel@deadeye \
    --to=ben@decadent.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).