From: swarren@nvidia.com (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: tegra: Introduce define DEBUG_UART_SHIFT
Date: Tue, 3 Jan 2012 15:25:17 -0700 [thread overview]
Message-ID: <1325629520-23018-2-git-send-email-swarren@nvidia.com> (raw)
In-Reply-To: <1325629520-23018-1-git-send-email-swarren@nvidia.com>
From: Doug Anderson <dianders@chromium.org>
This removes the need for the variable "shift" in all functions in
uncompress.h.
Signed-off-by: Doug Anderson <dianders@chromium.org>
[swarren: Extracted from a larger patch by Doug]
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/mach-tegra/include/mach/uncompress.h | 18 ++++++++++--------
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-tegra/include/mach/uncompress.h b/arch/arm/mach-tegra/include/mach/uncompress.h
index 39bd5e5..9797279 100644
--- a/arch/arm/mach-tegra/include/mach/uncompress.h
+++ b/arch/arm/mach-tegra/include/mach/uncompress.h
@@ -2,10 +2,12 @@
* arch/arm/mach-tegra/include/mach/uncompress.h
*
* Copyright (C) 2010 Google, Inc.
+ * Copyright (C) 2011 Google, Inc.
*
* Author:
* Colin Cross <ccross@google.com>
* Erik Gilling <konkers@google.com>
+ * Doug Anderson <dianders@chromium.org>
*
* This software is licensed under the terms of the GNU General Public
* License version 2, as published by the Free Software Foundation, and
@@ -26,17 +28,18 @@
#include <mach/iomap.h>
+#define DEBUG_UART_SHIFT 2
+
static void putc(int c)
{
volatile u8 *uart = (volatile u8 *)TEGRA_DEBUG_UART_BASE;
- int shift = 2;
if (uart == NULL)
return;
- while (!(uart[UART_LSR << shift] & UART_LSR_THRE))
+ while (!(uart[UART_LSR << DEBUG_UART_SHIFT] & UART_LSR_THRE))
barrier();
- uart[UART_TX << shift] = c;
+ uart[UART_TX << DEBUG_UART_SHIFT] = c;
}
static inline void flush(void)
@@ -48,7 +51,6 @@ static inline void arch_decomp_setup(void)
volatile u32 *apb_misc = (volatile u32 *)TEGRA_APB_MISC_BASE;
u32 chip, div;
volatile u8 *uart = (volatile u8 *)TEGRA_DEBUG_UART_BASE;
- int shift = 2;
if (uart == NULL)
return;
@@ -59,10 +61,10 @@ static inline void arch_decomp_setup(void)
else
div = 0x00dd;
- uart[UART_LCR << shift] |= UART_LCR_DLAB;
- uart[UART_DLL << shift] = div & 0xff;
- uart[UART_DLM << shift] = div >> 8;
- uart[UART_LCR << shift] = 3;
+ uart[UART_LCR << DEBUG_UART_SHIFT] |= UART_LCR_DLAB;
+ uart[UART_DLL << DEBUG_UART_SHIFT] = div & 0xff;
+ uart[UART_DLM << DEBUG_UART_SHIFT] = div >> 8;
+ uart[UART_LCR << DEBUG_UART_SHIFT] = 3;
}
static inline void arch_decomp_wdog(void)
--
1.7.0.4
next prev parent reply other threads:[~2012-01-03 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 22:25 [PATCH 0/4] ARM: tegra: Automatic UART selection for earlyprintk Stephen Warren
2012-01-03 22:25 ` Stephen Warren [this message]
2012-01-03 22:25 ` [PATCH 2/4] ARM: tegra: uncompress.h: Store UART address in a variable Stephen Warren
2012-01-03 22:25 ` [PATCH 3/4] ARM: tegra: uncompress.h: Choose a UART at runtime Stephen Warren
2012-01-03 22:25 ` [PATCH 4/4] ARM: tegra: Pass uncompress.h UART selection to DEBUG_LL Stephen Warren
2012-01-04 23:45 ` [PATCH 0/4] ARM: tegra: Automatic UART selection for earlyprintk Doug Anderson
2012-01-04 23:47 ` Doug Anderson
2012-01-05 22:03 ` Stephen Warren
2012-01-19 4:42 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325629520-23018-2-git-send-email-swarren@nvidia.com \
--to=swarren@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).