From: richard.zhao@linaro.org (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] dma/imx-sdma: use writel to write register when enable a channel
Date: Thu, 5 Jan 2012 15:59:22 +0800 [thread overview]
Message-ID: <1325750362-22598-3-git-send-email-richard.zhao@linaro.org> (raw)
In-Reply-To: <1325750362-22598-1-git-send-email-richard.zhao@linaro.org>
dma_alloc_coherent memory may be bufferable when set
CONFIG_ARM_DMA_MEM_BUFFERABLE. We need to add nececcary
memory barrier. writel implicitly call wmb in such case.
Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
---
drivers/dma/imx-sdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index c2bc4f1..e987468 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -396,7 +396,7 @@ static int sdma_config_ownership(struct sdma_channel *sdmac,
static void sdma_enable_channel(struct sdma_engine *sdma, int channel)
{
- __raw_writel(1 << channel, sdma->regs + SDMA_H_START);
+ writel(1 << channel, sdma->regs + SDMA_H_START);
}
/*
--
1.7.5.4
next prev parent reply other threads:[~2012-01-05 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 7:59 [PATCH v3 0/2] imx-sdma: memory barrier fix Richard Zhao
2012-01-05 7:59 ` [PATCH v3 1/2] dma/imx-sdma: let sdma_run_channel call sdma_enable_channel Richard Zhao
2012-01-05 9:14 ` Shawn Guo
2012-01-05 7:59 ` Richard Zhao [this message]
2012-01-05 9:23 ` [PATCH v3 2/2] dma/imx-sdma: use writel to write register when enable a channel Shawn Guo
2012-01-05 9:19 ` Richard Zhao
2012-01-05 9:34 ` Eric Miao
2012-01-05 9:54 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325750362-22598-3-git-send-email-richard.zhao@linaro.org \
--to=richard.zhao@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).