From: ulf.hansson@stericsson.com (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] mmc: mmci: Use ios_handler to save power
Date: Tue, 17 Jan 2012 15:34:23 +0100 [thread overview]
Message-ID: <1326810867-5346-5-git-send-email-ulf.hansson@stericsson.com> (raw)
In-Reply-To: <1326810867-5346-1-git-send-email-ulf.hansson@stericsson.com>
To disable a levelshifter when we are in an idle state will
decrease current consumption. We make use of the ios_handler
at runtime suspend and at regular suspend to accomplish this.
Of course depending on the used levelshifter the decrease of
current differs. For ST6G3244ME the value is up to ~200 uA.
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/mmc/host/mmci.c | 19 ++++++++++++++++++-
1 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index a7c8f8f..76ce2cd 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -1505,10 +1505,22 @@ static int mmci_save(struct amba_device *dev)
{
struct mmc_host *mmc = amba_get_drvdata(dev);
unsigned long flags;
+ struct mmc_ios ios;
+ int ret = 0;
if (mmc) {
struct mmci_host *host = mmc_priv(mmc);
+ /* Let the ios_handler act on a POWER_OFF to save power. */
+ if (host->plat->ios_handler) {
+ memcpy(&ios, &mmc->ios, sizeof(struct mmc_ios));
+ ios.power_mode = MMC_POWER_OFF;
+ ret = host->plat->ios_handler(mmc_dev(mmc),
+ &ios);
+ if (ret)
+ return ret;
+ }
+
spin_lock_irqsave(&host->lock, flags);
/*
@@ -1527,7 +1539,7 @@ static int mmci_save(struct amba_device *dev)
amba_vcore_disable(dev);
}
- return 0;
+ return ret;
}
static int mmci_restore(struct amba_device *dev)
@@ -1550,6 +1562,11 @@ static int mmci_restore(struct amba_device *dev)
writel(MCI_IRQENABLE, host->base + MMCIMASK0);
spin_unlock_irqrestore(&host->lock, flags);
+
+ /* Restore settings done by the ios_handler. */
+ if (host->plat->ios_handler)
+ host->plat->ios_handler(mmc_dev(mmc),
+ &mmc->ios);
}
return 0;
--
1.7.5.4
next prev parent reply other threads:[~2012-01-17 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 14:34 [PATCH 0/8] mmc: mmci: Improved PM and SDIO support Ulf Hansson
2012-01-17 14:34 ` [PATCH 1/8] mmc: mmci: Cache MMCICLOCK and MMCIPOWER register Ulf Hansson
2012-01-17 14:34 ` [PATCH 2/8] mmc: mmci: Decrease current consumption in suspend Ulf Hansson
2012-01-17 14:34 ` [PATCH 3/8] mmc: mmci: Implement PM runtime callbacks to save power Ulf Hansson
2012-01-17 14:34 ` Ulf Hansson [this message]
2012-04-18 11:57 ` [PATCH 4/8] mmc: mmci: Use ios_handler " Vitaly Wool
2012-04-18 13:45 ` Russell King - ARM Linux
2012-05-08 11:57 ` Ulf Hansson
2012-01-17 14:34 ` [PATCH 5/8] mmc: mmci: Support MMC_PM_KEEP_POWER Ulf Hansson
2012-01-17 14:34 ` [PATCH 6/8] mmc: mmci: Fix incorrect handling of HW flow control for SDIO Ulf Hansson
2012-01-17 14:34 ` [PATCH 7/8] mmc: mmci: Add constraints on alignment " Ulf Hansson
2012-01-17 14:34 ` [PATCH 8/8] mmc: mmci: Support any block sizes for ux500v2 variant Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326810867-5346-5-git-send-email-ulf.hansson@stericsson.com \
--to=ulf.hansson@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).