From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] at91 : remove wait_for_interrupt definition
Date: Wed, 18 Jan 2012 00:40:19 +0100 [thread overview]
Message-ID: <1326843620-13148-4-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1326843620-13148-1-git-send-email-daniel.lezcano@linaro.org>
All the "wait_for_interrupt" definition are aliases to cpu_do_idle.
Only the rm9200 has an asm routine to switch to wfi. But the cpu_do_idle
for this platform has exactly the same asm routine.
arch/arm/mm/proc-arm920.S
...
ENTRY(cpu_arm920_do_idle)
mcr p15, 0, r0, c7, c0, 4 @ Wait for interrupt
...
Then it is safe to invoke cpu_do_idle for this platform. As all the
wait_for_interrupts are definition for cpu_do_idle, let's remove it
and replace its invokation by cpu_do_idle.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
arch/arm/mach-at91/pm.c | 2 +-
arch/arm/mach-at91/pm.h | 12 ------------
2 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index 62ad955..acf32c7 100644
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -272,7 +272,7 @@ static int at91_pm_enter(suspend_state_t state)
: /* no input */
: "r0");
saved_lpr = sdram_selfrefresh_enable();
- wait_for_interrupt_enable();
+ cpu_do_idle();
sdram_selfrefresh_disable(saved_lpr);
break;
diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
index 325ef76..624c99c 100644
--- a/arch/arm/mach-at91/pm.h
+++ b/arch/arm/mach-at91/pm.h
@@ -36,10 +36,6 @@ static inline u32 sdram_selfrefresh_enable(void)
#define sdram_selfrefresh_disable(saved_lpr) \
at91_sys_write(AT91_SDRAMC_LPR, saved_lpr)
-#define wait_for_interrupt_enable() \
- asm volatile ("mcr p15, 0, %0, c7, c0, 4" \
- : : "r" (0))
-
#elif defined(CONFIG_ARCH_AT91CAP9)
#include <mach/at91cap9_ddrsdr.h>
@@ -58,9 +54,6 @@ static inline u32 sdram_selfrefresh_enable(void)
#define sdram_selfrefresh_disable(saved_lpr) \
at91_ramc_write(0, AT91_DDRSDRC_LPR, saved_lpr)
-#define wait_for_interrupt_enable() \
- cpu_do_idle()
-
#elif defined(CONFIG_ARCH_AT91SAM9G45)
#include <mach/at91sam9_ddrsdr.h>
@@ -97,8 +90,6 @@ static inline u32 sdram_selfrefresh_enable(void)
at91_ramc_write(1, AT91_DDRSDRC_LPR, saved_lpr1); \
} while (0)
-#define wait_for_interrupt_enable() cpu_do_idle()
-
#else
#include <mach/at91sam9_sdramc.h>
@@ -125,9 +116,6 @@ static inline u32 sdram_selfrefresh_enable(void)
#define sdram_selfrefresh_disable(saved_lpr) \
at91_ramc_write(0, AT91_SDRAMC_LPR, saved_lpr)
-#define wait_for_interrupt_enable() \
- cpu_do_idle()
-
#endif
#endif
--
1.7.5.4
next prev parent reply other threads:[~2012-01-17 23:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 23:40 [PATCH 0/4] at91 : cleanup pm.h Daniel Lezcano
2012-01-17 23:40 ` [PATCH 1/4] at91 : coding style fixes Daniel Lezcano
2012-01-17 23:40 ` [PATCH 2/4] at91 : declare header name Daniel Lezcano
2012-01-17 23:40 ` Daniel Lezcano [this message]
2012-01-18 21:53 ` [PATCH 3/4] at91 : remove wait_for_interrupt definition Ryan Mallon
2012-01-17 23:40 ` [PATCH 4/4] at91 : implement the standby function for pm/cpuidle Daniel Lezcano
2012-01-18 22:08 ` Ryan Mallon
2012-01-18 22:18 ` Russell King - ARM Linux
2012-01-18 22:25 ` Ryan Mallon
2012-01-18 22:45 ` Russell King - ARM Linux
2012-01-19 9:18 ` Daniel Lezcano
2012-01-19 9:25 ` [PATCH 0/4] at91 : cleanup pm.h Nicolas Ferre
-- strict thread matches above, loose matches on Subject: below --
2012-01-24 23:56 [PATCH 1/4] at91 : coding style fixes Daniel Lezcano
2012-01-24 23:56 ` [PATCH 3/4] at91 : remove wait_for_interrupt definition Daniel Lezcano
2012-01-25 0:18 ` Russell King - ARM Linux
2012-01-25 14:39 ` Daniel Lezcano
2012-02-27 12:50 ` Russell King - ARM Linux
2012-02-27 13:07 ` Daniel Lezcano
2012-02-27 14:52 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326843620-13148-4-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).