* [PATCH] arm: fix build failure in mach-bcmring/arch.c
@ 2012-01-22 20:26 Paul Gortmaker
2012-01-24 0:52 ` Jiandong Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Paul Gortmaker @ 2012-01-22 20:26 UTC (permalink / raw)
To: linux-arm-kernel
Upstream commit d1fce9c115eeb93e01c01732dfe9a86cf76009cf
"ARM: restart: bcmring: use new restart hook"
breaks building of this platform, since what used to be the
last field of the MACHINE_START/END block didn't have a
trailing comma. Once another field was added below, we get:
arch/arm/mach-bcmring/arch.c:198: error: request for member 'restart' in something not a structure or union
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/arch/arm/mach-bcmring/arch.c b/arch/arm/mach-bcmring/arch.c
index 9e5e755..45c97b1 100644
--- a/arch/arm/mach-bcmring/arch.c
+++ b/arch/arm/mach-bcmring/arch.c
@@ -194,6 +194,6 @@ MACHINE_START(BCMRING, "BCMRING")
.init_early = bcmring_init_early,
.init_irq = bcmring_init_irq,
.timer = &bcmring_timer,
- .init_machine = bcmring_init_machine
+ .init_machine = bcmring_init_machine,
.restart = bcmring_restart,
MACHINE_END
--
1.7.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] arm: fix build failure in mach-bcmring/arch.c
2012-01-22 20:26 [PATCH] arm: fix build failure in mach-bcmring/arch.c Paul Gortmaker
@ 2012-01-24 0:52 ` Jiandong Zheng
2012-02-04 19:30 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Jiandong Zheng @ 2012-01-24 0:52 UTC (permalink / raw)
To: linux-arm-kernel
On 1/22/2012 12:26 PM, Paul Gortmaker wrote:
> Upstream commit d1fce9c115eeb93e01c01732dfe9a86cf76009cf
>
> "ARM: restart: bcmring: use new restart hook"
>
> breaks building of this platform, since what used to be the
> last field of the MACHINE_START/END block didn't have a
> trailing comma. Once another field was added below, we get:
>
> arch/arm/mach-bcmring/arch.c:198: error: request for member 'restart' in something not a structure or union
>
> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>
> diff --git a/arch/arm/mach-bcmring/arch.c b/arch/arm/mach-bcmring/arch.c
> index 9e5e755..45c97b1 100644
> --- a/arch/arm/mach-bcmring/arch.c
> +++ b/arch/arm/mach-bcmring/arch.c
> @@ -194,6 +194,6 @@ MACHINE_START(BCMRING, "BCMRING")
> .init_early = bcmring_init_early,
> .init_irq = bcmring_init_irq,
> .timer =&bcmring_timer,
> - .init_machine = bcmring_init_machine
> + .init_machine = bcmring_init_machine,
> .restart = bcmring_restart,
> MACHINE_END
Acked-by: Jiandong Zheng <jdzheng@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm: fix build failure in mach-bcmring/arch.c
2012-01-24 0:52 ` Jiandong Zheng
@ 2012-02-04 19:30 ` Olof Johansson
0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2012-02-04 19:30 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 23, 2012 at 4:52 PM, Jiandong Zheng <jdzheng@broadcom.com> wrote:
> On 1/22/2012 12:26 PM, Paul Gortmaker wrote:
>>
>> Upstream commit d1fce9c115eeb93e01c01732dfe9a86cf76009cf
>>
>> ? ? "ARM: restart: bcmring: use new restart hook"
>>
>> breaks building of this platform, since what used to be the
>> last field of the MACHINE_START/END block didn't have a
>> trailing comma. ?Once another field was added below, we get:
>>
>> arch/arm/mach-bcmring/arch.c:198: error: request for member 'restart' in
>> something not a structure or union
>>
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>>
>> diff --git a/arch/arm/mach-bcmring/arch.c b/arch/arm/mach-bcmring/arch.c
>> index 9e5e755..45c97b1 100644
>> --- a/arch/arm/mach-bcmring/arch.c
>> +++ b/arch/arm/mach-bcmring/arch.c
>> @@ -194,6 +194,6 @@ MACHINE_START(BCMRING, "BCMRING")
>> ? ? ? ?.init_early = bcmring_init_early,
>> ? ? ? ?.init_irq = bcmring_init_irq,
>> ? ? ? ?.timer =&bcmring_timer,
>> - ? ? ? .init_machine = bcmring_init_machine
>> + ? ? ? .init_machine = bcmring_init_machine,
>> ? ? ? ?.restart = bcmring_restart,
>> ?MACHINE_END
>
>
> Acked-by: Jiandong Zheng <jdzheng@broadcom.com>
Thanks, applied to arm-soc fixes for -rc.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-04 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-22 20:26 [PATCH] arm: fix build failure in mach-bcmring/arch.c Paul Gortmaker
2012-01-24 0:52 ` Jiandong Zheng
2012-02-04 19:30 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).