linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jean.pihet@newoldbits.com (Jean Pihet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq
Date: Wed, 25 Jan 2012 16:16:06 +0100	[thread overview]
Message-ID: <1327504583-13408-5-git-send-email-j-pihet@ti.com> (raw)
In-Reply-To: <1327504583-13408-1-git-send-email-j-pihet@ti.com>

From: Colin Cross <ccross@android.com>

Running without smartreflex for any significant time (on the order
of seconds) is unsafe and can cause thermal runaway.  Move
smartreflex suspend into suspend_noirq, so it happens as late as
possible.  This prevents hangs that occur in a driver suspend
handler from running without smartreflex enabled.  It will also
reduce power used during suspend and resume, as the voltages will
be lowered.

May also indirectly fix imprecise external aborts seen during
suspend, which could be caused by calls to sr_disable racing
from calls to dvfs_scale and omap_sr_disable.

Change-Id: Ia3c1e707bb1022ec102f506dc3ad48906e8890da
Signed-off-by: Colin Cross <ccross@android.com>
Signed-off-by: Jean Pihet <j-pihet@ti.com>
---
 arch/arm/mach-omap2/smartreflex.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index fca8df69..95fd228 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -1095,7 +1095,10 @@ static int omap_sr_resume(struct device *dev)
 	return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(omap_sr_dev_pm_ops, omap_sr_suspend, omap_sr_resume);
+const static struct dev_pm_ops omap_sr_dev_pm_ops = {
+	.suspend_noirq = omap_sr_suspend,
+	.resume_noirq = omap_sr_resume,
+};
 
 static struct platform_driver smartreflex_driver = {
 	.remove         = omap_sr_remove,
-- 
1.7.5.4

  parent reply	other threads:[~2012-01-25 15:16 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 15:16 [PATCH 00/21] OMAP3+: SR: bugfixes Jean Pihet
2012-01-25 15:16 ` [PATCH 01/21] OMAP3+: SR Layer Cleanup [V4] Jean Pihet
2012-01-25 15:16 ` [PATCH 02/21] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code Jean Pihet
2012-01-25 15:16 ` [PATCH 03/21] OMAP3+: PM: SR: add suspend/resume handlers Jean Pihet
2012-01-25 15:16 ` Jean Pihet [this message]
2012-01-25 18:29   ` [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 05/21] Revert "OMAP3+: PM: SR: add suspend/resume handlers" Jean Pihet
2012-01-25 17:53   ` Cousson, Benoit
2012-01-25 18:13     ` Jean Pihet
2012-01-25 18:25       ` Cousson, Benoit
2012-01-25 18:49         ` Kevin Hilman
2012-01-25 21:29           ` Menon, Nishanth
2012-01-26  7:31             ` Jean Pihet
2012-01-25 15:16 ` [PATCH 06/21] OMAP3+: Smartreflex: fix err interrupt disable sequence Jean Pihet
2012-01-25 15:16 ` [PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP Jean Pihet
2012-01-26 11:26   ` Sergei Shtylyov
2012-01-31 10:06     ` Jean Pihet
2012-01-31 11:37       ` Sergei Shtylyov
2012-01-31 13:39         ` Jean Pihet
2012-01-25 15:16 ` [PATCH 08/21] OMAP3+: Smartreflex: Add a shutdown hook Jean Pihet
2012-01-26 11:21   ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 09/21] OMAP3+: Smartreflex: Fix status masking in ERRCONFIG register Jean Pihet
2012-01-26 11:28   ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 10/21] OMAP3+: Smartreflex: clear ERRCONFIG_VPBOUNDINTST only on a need Jean Pihet
2012-01-26 11:29   ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 11/21] OMAP3: hwmod: add SmartReflex IRQs Jean Pihet
2012-01-26 11:30   ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 12/21] OMAP3+: SR: introduce class init,deinit and priv data Jean Pihet
2012-01-26 11:31   ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 13/21] OMAP3+: SR: introduce notifiers flags Jean Pihet
2012-01-25 15:16 ` [PATCH 14/21] OMAP3+: SR: introduce notifier_control Jean Pihet
2012-01-25 15:16 ` [PATCH 15/21] OMAP3+: SR: disable spamming interrupts Jean Pihet
2012-01-25 15:16 ` [PATCH 16/21] OMAP3+: SR: introduce class private data per voltage domain Jean Pihet
2012-01-25 15:16 ` [PATCH 17/21] OMAP3430: SR: class3: restrict CPU to run on Jean Pihet
2012-01-26 11:33   ` Sergei Shtylyov
2012-01-26 12:22     ` Jean Pihet
2012-01-25 15:16 ` [PATCH 18/21] arm: omap: smartreflex: add missing platform_set_drvdata() Jean Pihet
2012-01-25 15:16 ` [PATCH 19/21] arm: omap: smartreflex: move late_initcall() closer to its argument Jean Pihet
2012-01-25 15:16 ` [PATCH 20/21] arm: omap: smartreflex: clean ups all over Jean Pihet
2012-01-25 15:16 ` [PATCH 21/21] arm: omap: smartreflex: micro-optimization for sanity check Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327504583-13408-5-git-send-email-j-pihet@ti.com \
    --to=jean.pihet@newoldbits.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).