From mboxrd@z Thu Jan 1 00:00:00 1970 From: jean.pihet@newoldbits.com (Jean Pihet) Date: Tue, 31 Jan 2012 10:58:32 +0100 Subject: [PATCH 19/19] ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API In-Reply-To: <1328003912-11709-1-git-send-email-j-pihet@ti.com> References: <1328003912-11709-1-git-send-email-j-pihet@ti.com> Message-ID: <1328003912-11709-20-git-send-email-j-pihet@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The debugfs_create_* API returns a NULL ptr in case of problem. Fix the smartreflex code to take this into account. Signed-off-by: Jean Pihet --- arch/arm/mach-omap2/smartreflex.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 2fe882f..a9afaf7 100644 --- a/arch/arm/mach-omap2/smartreflex.c +++ b/arch/arm/mach-omap2/smartreflex.c @@ -1169,7 +1169,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) if (!sr_dbg_dir) { sr_dbg_dir = debugfs_create_dir("smartreflex", NULL); if (!sr_dbg_dir) { - ret = PTR_ERR(sr_dbg_dir); + ret = -ENOMEM; pr_err("%s:sr debugfs dir creation failed(%d)\n", __func__, ret); goto err_iounmap; @@ -1185,10 +1185,10 @@ static int __init omap_sr_probe(struct platform_device *pdev) } sr_info->dbg_dir = debugfs_create_dir(name, sr_dbg_dir); kfree(name); - if (IS_ERR(sr_info->dbg_dir)) { + if (!sr_info->dbg_dir) { dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n", __func__); - ret = PTR_ERR(sr_info->dbg_dir); + ret = -ENOMEM; goto err_iounmap; } @@ -1202,10 +1202,10 @@ static int __init omap_sr_probe(struct platform_device *pdev) &sr_info->err_minlimit); nvalue_dir = debugfs_create_dir("nvalue", sr_info->dbg_dir); - if (IS_ERR(nvalue_dir)) { + if (!nvalue_dir) { dev_err(&pdev->dev, "%s: Unable to create debugfs directory" "for n-values\n", __func__); - ret = PTR_ERR(nvalue_dir); + ret = -ENOMEM; goto err_debugfs; } -- 1.7.5.4