From: jean.pihet@newoldbits.com (Jean Pihet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/20] ARM: OMAP3+: SmartReflex: introduce class init, deinit and priv data
Date: Wed, 1 Feb 2012 09:49:48 +0100 [thread overview]
Message-ID: <1328086199-28486-10-git-send-email-j-pihet@ti.com> (raw)
In-Reply-To: <1328086199-28486-1-git-send-email-j-pihet@ti.com>
From: Nishanth Menon <nm@ti.com>
Certain class drivers such as class 1.5 drivers, will need specific
notification that they have to be inited up or deinited independent
of smart reflex operation. They also may need private data to be
used for operations of their own, provide the same.
This allows the class driver to initialize it's internal data structures
on a need basis in preparation for the specific domain's autocomp usage.
The resultant operation is as follows:
when autocomp is set to 1 -> class drivers' init is called
The existing enable/disable is still used as before by the SmartReflex
core driver to enable disable the class operation.
When autocomp is set to 0 -> class drivers' deinit is called, signaling
the end of usage for that domain.
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Jean Pihet <j-pihet@ti.com>
---
arch/arm/mach-omap2/smartreflex.c | 15 +++++++++++++++
arch/arm/mach-omap2/smartreflex.h | 6 ++++++
2 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index 6dea30d..5fd9cb1 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -218,6 +218,13 @@ static void sr_start_vddautocomp(struct omap_sr *sr)
return;
}
+ if (sr_class->init &&
+ sr_class->init(sr->voltdm, sr_class->class_priv_data)) {
+ dev_err(&sr->pdev->dev,
+ "%s: SRClass initialization failed\n", __func__);
+ return;
+ }
+
if (!sr_class->enable(sr->voltdm))
sr->autocomp_active = true;
}
@@ -233,6 +240,14 @@ static void sr_stop_vddautocomp(struct omap_sr *sr)
if (sr->autocomp_active) {
sr_class->disable(sr->voltdm, 1);
+ if (sr_class->deinit &&
+ sr_class->deinit(sr->voltdm,
+ sr_class->class_priv_data)) {
+ dev_err(&sr->pdev->dev,
+ "%s: SR[%d]Class deinitialization failed\n",
+ __func__, sr->srid);
+ }
+
sr->autocomp_active = false;
}
}
diff --git a/arch/arm/mach-omap2/smartreflex.h b/arch/arm/mach-omap2/smartreflex.h
index 5809141..dd5b21e 100644
--- a/arch/arm/mach-omap2/smartreflex.h
+++ b/arch/arm/mach-omap2/smartreflex.h
@@ -177,6 +177,8 @@ struct omap_smartreflex_dev_attr {
*
* @enable: API to enable a particular class smaartreflex.
* @disable: API to disable a particular class smartreflex.
+ * @init: API to do class specific initialization (optional)
+ * @deinit: API to do class specific deinitialization (optional)
* @configure: API to configure a particular class smartreflex.
* @notify: API to notify the class driver about an event in SR.
* Not needed for class3.
@@ -184,14 +186,18 @@ struct omap_smartreflex_dev_attr {
* @class_type: specify which smartreflex class.
* Can be used by the SR driver to take any class
* based decisions.
+ * @class_priv_data: Class specific private data (optional)
*/
struct omap_sr_class_data {
int (*enable)(struct voltagedomain *voltdm);
int (*disable)(struct voltagedomain *voltdm, int is_volt_reset);
+ int (*init)(struct voltagedomain *voltdm, void *class_priv_data);
+ int (*deinit)(struct voltagedomain *voltdm, void *class_priv_data);
int (*configure)(struct voltagedomain *voltdm);
int (*notify)(struct voltagedomain *voltdm, u32 status);
u8 notify_flags;
u8 class_type;
+ void *class_priv_data;
};
/**
--
1.7.5.4
next prev parent reply other threads:[~2012-02-01 8:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 8:49 [PATCH v3 00/20] ARM: OMAP3+: SmartReflex: bugfixes Jean Pihet
2012-02-01 8:49 ` [PATCH 01/20] ARM: OMAP3+: SmartReflex: Layer Cleanup [V4] Jean Pihet
2012-02-01 8:49 ` [PATCH 02/20] ARM: OMAP3+: SmartReflex: add missing error-handling code Jean Pihet
2012-02-01 8:49 ` [PATCH 03/20] ARM: OMAP3+: SmartReflex: fix err interrupt disable sequence Jean Pihet
2012-02-01 8:49 ` [PATCH 04/20] ARM: OMAP3+: SmartReflex Class3: disable errorgen before disable VP Jean Pihet
2012-02-01 8:49 ` [PATCH 05/20] ARM: OMAP3+: SmartReflex: Add a shutdown hook Jean Pihet
2012-02-01 8:49 ` [PATCH 06/20] ARM: OMAP3+: SmartReflex: Fix status masking in ERRCONFIG register Jean Pihet
2012-02-01 8:49 ` [PATCH 07/20] ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need Jean Pihet
2012-02-02 19:15 ` Kevin Hilman
2012-02-01 8:49 ` [PATCH 08/20] ARM: OMAP3+: hwmod: add SmartReflex IRQs Jean Pihet
2012-02-01 8:49 ` Jean Pihet [this message]
2012-02-01 8:49 ` [PATCH 10/20] ARM: OMAP3+: SmartReflex: introduce notifiers flags Jean Pihet
2012-02-01 8:49 ` [PATCH 11/20] ARM: OMAP3+: SmartReflex: introduce notifier_control Jean Pihet
2012-02-01 8:49 ` [PATCH 12/20] ARM: OMAP3+: SmartReflex: disable spamming interrupts Jean Pihet
2012-02-01 8:49 ` [PATCH 13/20] ARM: OMAP3+: SmartReflex: introduce class private data per voltage domain Jean Pihet
2012-02-01 8:49 ` [PATCH 14/20] ARM: OMAP3+: SmartReflex Class3: restrict CPU to run on Jean Pihet
2012-02-01 8:49 ` [PATCH 15/20] ARM: OMAP3+: SmartReflex: add missing platform_set_drvdata() Jean Pihet
2012-02-01 8:49 ` [PATCH 16/20] ARM: OMAP3+: SmartReflex: move late_initcall() closer to its argument Jean Pihet
2012-02-01 8:49 ` [PATCH 17/20] ARM: OMAP3+: SmartReflex: misc cleanups Jean Pihet
2012-02-01 8:49 ` [PATCH 18/20] ARM: OMAP3+: SmartReflex: micro-optimization for sanity check Jean Pihet
2012-02-01 8:49 ` [PATCH 19/20] ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API Jean Pihet
2012-02-01 8:49 ` [PATCH 20/20] ARM: OMAP3+: SmartReflex: fix error handling Jean Pihet
2012-02-02 19:23 ` [PATCH v3 00/20] ARM: OMAP3+: SmartReflex: bugfixes Kevin Hilman
2012-02-08 17:52 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328086199-28486-10-git-send-email-j-pihet@ti.com \
--to=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).