From: jean.pihet@newoldbits.com (Jean Pihet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/20] ARM: OMAP3+: SmartReflex: fix err interrupt disable sequence
Date: Wed, 1 Feb 2012 09:49:42 +0100 [thread overview]
Message-ID: <1328086199-28486-4-git-send-email-j-pihet@ti.com> (raw)
In-Reply-To: <1328086199-28486-1-git-send-email-j-pihet@ti.com>
From: Nishanth Menon <nm@ti.com>
sr_modify_mask takes mask, value as parameters, the usage
currently is value, mask which is wrong, as a result
vpboundint_st which was supposed to have been disabled,
does not get disabled.
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Jean Pihet <j-pihet@ti.com>
---
arch/arm/mach-omap2/smartreflex.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index 7e755bb..ee224df 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -447,8 +447,8 @@ int sr_configure_errgen(struct voltagedomain *voltdm)
sr_errconfig);
/* Enabling the interrupts if the ERROR module is used */
- sr_modify_reg(sr, errconfig_offs,
- vpboundint_en, (vpboundint_en | vpboundint_st));
+ sr_modify_reg(sr, errconfig_offs, (vpboundint_en | vpboundint_st),
+ vpboundint_en);
return 0;
}
--
1.7.5.4
next prev parent reply other threads:[~2012-02-01 8:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 8:49 [PATCH v3 00/20] ARM: OMAP3+: SmartReflex: bugfixes Jean Pihet
2012-02-01 8:49 ` [PATCH 01/20] ARM: OMAP3+: SmartReflex: Layer Cleanup [V4] Jean Pihet
2012-02-01 8:49 ` [PATCH 02/20] ARM: OMAP3+: SmartReflex: add missing error-handling code Jean Pihet
2012-02-01 8:49 ` Jean Pihet [this message]
2012-02-01 8:49 ` [PATCH 04/20] ARM: OMAP3+: SmartReflex Class3: disable errorgen before disable VP Jean Pihet
2012-02-01 8:49 ` [PATCH 05/20] ARM: OMAP3+: SmartReflex: Add a shutdown hook Jean Pihet
2012-02-01 8:49 ` [PATCH 06/20] ARM: OMAP3+: SmartReflex: Fix status masking in ERRCONFIG register Jean Pihet
2012-02-01 8:49 ` [PATCH 07/20] ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need Jean Pihet
2012-02-02 19:15 ` Kevin Hilman
2012-02-01 8:49 ` [PATCH 08/20] ARM: OMAP3+: hwmod: add SmartReflex IRQs Jean Pihet
2012-02-01 8:49 ` [PATCH 09/20] ARM: OMAP3+: SmartReflex: introduce class init, deinit and priv data Jean Pihet
2012-02-01 8:49 ` [PATCH 10/20] ARM: OMAP3+: SmartReflex: introduce notifiers flags Jean Pihet
2012-02-01 8:49 ` [PATCH 11/20] ARM: OMAP3+: SmartReflex: introduce notifier_control Jean Pihet
2012-02-01 8:49 ` [PATCH 12/20] ARM: OMAP3+: SmartReflex: disable spamming interrupts Jean Pihet
2012-02-01 8:49 ` [PATCH 13/20] ARM: OMAP3+: SmartReflex: introduce class private data per voltage domain Jean Pihet
2012-02-01 8:49 ` [PATCH 14/20] ARM: OMAP3+: SmartReflex Class3: restrict CPU to run on Jean Pihet
2012-02-01 8:49 ` [PATCH 15/20] ARM: OMAP3+: SmartReflex: add missing platform_set_drvdata() Jean Pihet
2012-02-01 8:49 ` [PATCH 16/20] ARM: OMAP3+: SmartReflex: move late_initcall() closer to its argument Jean Pihet
2012-02-01 8:49 ` [PATCH 17/20] ARM: OMAP3+: SmartReflex: misc cleanups Jean Pihet
2012-02-01 8:49 ` [PATCH 18/20] ARM: OMAP3+: SmartReflex: micro-optimization for sanity check Jean Pihet
2012-02-01 8:49 ` [PATCH 19/20] ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API Jean Pihet
2012-02-01 8:49 ` [PATCH 20/20] ARM: OMAP3+: SmartReflex: fix error handling Jean Pihet
2012-02-02 19:23 ` [PATCH v3 00/20] ARM: OMAP3+: SmartReflex: bugfixes Kevin Hilman
2012-02-08 17:52 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328086199-28486-4-git-send-email-j-pihet@ti.com \
--to=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).