From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: orion5x: print mac address with %pM
Date: Wed, 8 Feb 2012 12:13:27 +0200 [thread overview]
Message-ID: <1328696007-27538-2-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1328696007-27538-1-git-send-email-andriy.shevchenko@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Nicolas Pitre <nico@fluxnic.net>
---
arch/arm/mach-orion5x/dns323-setup.c | 7 +++----
arch/arm/mach-orion5x/tsx09-common.c | 4 +---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c
index 9eec294..9e12ef8 100644
--- a/arch/arm/mach-orion5x/dns323-setup.c
+++ b/arch/arm/mach-orion5x/dns323-setup.c
@@ -201,9 +201,8 @@ static int __init dns323_read_mac_addr(void)
}
iounmap(mac_page);
- printk("DNS-323: Found ethernet MAC address: ");
- for (i = 0; i < 6; i++)
- printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
+
+ pr_info("DNS-323: Found ethernet MAC address: %pM.\n", addr);
memcpy(dns323_eth_data.mac_addr, addr, 6);
@@ -637,7 +636,7 @@ static void __init dns323_init(void)
* Configure peripherals.
*/
if (dns323_read_mac_addr() < 0)
- printk("DNS-323: Failed to read MAC address\n");
+ pr_warning("DNS-323: Failed to read MAC address\n");
orion5x_ehci0_init();
orion5x_eth_init(&dns323_eth_data);
orion5x_i2c_init();
diff --git a/arch/arm/mach-orion5x/tsx09-common.c b/arch/arm/mach-orion5x/tsx09-common.c
index e65b528f..c2d813c 100644
--- a/arch/arm/mach-orion5x/tsx09-common.c
+++ b/arch/arm/mach-orion5x/tsx09-common.c
@@ -71,9 +71,7 @@ static int __init qnap_tsx09_check_mac_addr(const char *addr_str)
return -1;
}
- printk(KERN_INFO "tsx09: found ethernet mac address ");
- for (i = 0; i < 6; i++)
- printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
+ pr_info("tsx09: found ethernet mac address %pM.\n", addr);
memcpy(qnap_tsx09_eth_data.mac_addr, addr, 6);
--
1.7.9
next prev parent reply other threads:[~2012-02-08 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 10:13 [PATCH 1/2] arm: orion5x: use native hex2bin() Andy Shevchenko
2012-02-08 10:13 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-29 15:13 Andy Shevchenko
2011-09-29 15:14 ` [PATCH 2/2] arm: orion5x: print mac address with %pM Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328696007-27538-2-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).