From: jean.pihet@newoldbits.com (Jean Pihet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/14] ARM: OMAP3+: SmartReflex: Add a shutdown hook
Date: Wed, 8 Feb 2012 18:43:49 +0100 [thread overview]
Message-ID: <1328723039-15952-5-git-send-email-j-pihet@ti.com> (raw)
In-Reply-To: <1328723039-15952-1-git-send-email-j-pihet@ti.com>
From: Nishanth Menon <nm@ti.com>
SmartReflex fix for erratum ID i724.
Since OMAP's VP and PRM modules do not get reset by warm reset,
we should ensure that proper shutdown procedure is followed prior
to allowing the kernel to reboot back up.
Without this patch, Smartreflex module might be left active or
system might be caught in an indeterminate sequence when reboot
is triggered, leaving the next reboot behavior to be unpredictable.
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Jean Pihet <j-pihet@ti.com>
---
arch/arm/mach-omap2/smartreflex.c | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index ec2b0e7..9c39484 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -1055,8 +1055,32 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
return 0;
}
+static void __devexit omap_sr_shutdown(struct platform_device *pdev)
+{
+ struct omap_sr_data *pdata = pdev->dev.platform_data;
+ struct omap_sr *sr_info;
+
+ if (!pdata) {
+ dev_err(&pdev->dev, "%s: platform data missing\n", __func__);
+ return;
+ }
+
+ sr_info = _sr_lookup(pdata->voltdm);
+ if (IS_ERR(sr_info)) {
+ dev_warn(&pdev->dev, "%s: omap_sr struct not found\n",
+ __func__);
+ return;
+ }
+
+ if (sr_info->autocomp_active)
+ sr_stop_vddautocomp(sr_info);
+
+ return;
+}
+
static struct platform_driver smartreflex_driver = {
.remove = omap_sr_remove,
+ .shutdown = __devexit_p(omap_sr_shutdown),
.driver = {
.name = "smartreflex",
},
--
1.7.5.4
next prev parent reply other threads:[~2012-02-08 17:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 17:43 [PATCH v4 00/14] ARM: OMAP3+: SmartReflex: bugfixes and clean-ups Jean Pihet
2012-02-08 17:43 ` [PATCH 01/14] ARM: OMAP3+: SmartReflex: Layer Cleanup [V4] Jean Pihet
2012-02-28 22:37 ` Kevin Hilman
2012-02-08 17:43 ` [PATCH 02/14] ARM: OMAP3+: SmartReflex: fix err interrupt disable sequence Jean Pihet
2012-02-08 17:43 ` [PATCH 03/14] ARM: OMAP3+: SmartReflex Class3: disable errorgen before disable VP Jean Pihet
2012-02-08 17:43 ` Jean Pihet [this message]
2012-02-28 22:40 ` [PATCH 04/14] ARM: OMAP3+: SmartReflex: Add a shutdown hook Kevin Hilman
2012-02-28 22:59 ` Menon, Nishanth
2012-02-29 18:07 ` Kevin Hilman
2012-02-29 23:33 ` Jean Pihet
2012-02-08 17:43 ` [PATCH 05/14] ARM: OMAP3+: SmartReflex: use __devexit_p annotation Jean Pihet
2012-02-08 17:43 ` [PATCH 06/14] ARM: OMAP3+: SmartReflex: Fix status masking in ERRCONFIG register Jean Pihet
2012-02-08 17:43 ` [PATCH 07/14] ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need Jean Pihet
2012-02-08 17:43 ` [PATCH 08/14] ARM: OMAP3+: hwmod: add SmartReflex IRQs Jean Pihet
2012-02-28 22:47 ` Kevin Hilman
2012-02-08 17:43 ` [PATCH 09/14] ARM: OMAP3+: SmartReflex: add missing platform_set_drvdata() Jean Pihet
2012-02-08 17:43 ` [PATCH 10/14] ARM: OMAP3+: SmartReflex: move late_initcall() closer to its argument Jean Pihet
2012-02-08 17:43 ` [PATCH 11/14] ARM: OMAP3+: SmartReflex: misc cleanups Jean Pihet
2012-02-08 17:43 ` [PATCH 12/14] ARM: OMAP3+: SmartReflex: micro-optimization for sanity check Jean Pihet
2012-02-08 17:43 ` [PATCH 13/14] ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API Jean Pihet
2012-02-08 17:43 ` [PATCH 14/14] ARM: OMAP3+: SmartReflex: fix error handling Jean Pihet
2012-02-28 22:50 ` [PATCH v4 00/14] ARM: OMAP3+: SmartReflex: bugfixes and clean-ups Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328723039-15952-5-git-send-email-j-pihet@ti.com \
--to=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).