From: coelho@ti.com (Luciano Coelho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3.3 v2] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
Date: Wed, 15 Feb 2012 09:20:02 +0200 [thread overview]
Message-ID: <1329290402.19569.24.camel@cumari> (raw)
In-Reply-To: <20120214203801.GU1426@atomide.com>
Hi Tony,
On Tue, 2012-02-14 at 12:38 -0800, Tony Lindgren wrote:
> * Luciano Coelho <coelho@ti.com> [120208 02:43]:
> > Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> >
> > arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> >
> > This is because of a missing include, which is added indirectly if
> > CONFIG_OF is defined. This problem was introduced in commit
> > 2f31b51 (ARM: OMAP4: PRM: use PRCM interrupt handler).
> >
> > Cc: Tero Kristo <t-kristo@ti.com>
> > Signed-off-by: Luciano Coelho <coelho@ti.com>
> > Reviewed-by: Felipe Balbi <balbi@ti.com>
>
> A similar patch should be already in mainline kernel queued by Russell.
Right, someone pointed this out to me after I sent the two patches.
Sorry for the trouble, I should have looked more carefully before
jumping in to fix this stuff. ;)
--
Cheers,
Luca.
prev parent reply other threads:[~2012-02-15 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 11:14 [PATCH 3.3 v2] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined Luciano Coelho
2012-02-14 20:38 ` Tony Lindgren
2012-02-15 7:20 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329290402.19569.24.camel@cumari \
--to=coelho@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).