From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: fix the wrong check condition
Date: Wed, 15 Feb 2012 18:33:28 +0800 [thread overview]
Message-ID: <1329302008-10228-1-git-send-email-b32955@freescale.com> (raw)
If we use `||` check condition, many NAND chips which are not
ONFI nands have to do the ONFI detection.
Use `&&` here to detect the ONFI NAND when we can not find any type
in the nand_flash_ids.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
drivers/mtd/nand/nand_base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 8a393f9..90020a5 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2966,7 +2966,7 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
break;
chip->onfi_version = 0;
- if (!type->name || !type->pagesize) {
+ if (!type->name && !type->pagesize) {
/* Check is chip is ONFI compliant */
ret = nand_flash_detect_onfi(mtd, chip, &busw);
if (ret)
--
1.7.3.2
next reply other threads:[~2012-02-15 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 10:33 Huang Shijie [this message]
2012-02-16 2:59 ` [PATCH] mtd: fix the wrong check condition Brian Norris
2012-02-16 3:15 ` Huang Shijie
2012-02-16 8:32 ` Brian Norris
[not found] ` <4F3C7433.5030306@freescale.com>
2012-02-16 11:04 ` Florian Fainelli
2012-02-17 3:07 ` Huang Shijie
2012-02-17 8:50 ` Florian Fainelli
2012-02-18 5:43 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329302008-10228-1-git-send-email-b32955@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).