From: tixy@yxit.co.uk (Tixy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dma-mapping: its array of pointer
Date: Sat, 18 Feb 2012 15:48:06 +0000 [thread overview]
Message-ID: <1329580086.2448.12.camel@computer2.home> (raw)
In-Reply-To: <1329484170-26329-1-git-send-email-ajeet.yadav.77@gmail.com>
On Fri, 2012-02-17 at 18:39 +0530, Ajeet Yadav wrote:
> To be consistant with declaration and usage of
^^^^^^^^^^
Spelling mistake, should be 'consistent'
> consistent_pte it need to be an array of (pte *)
^^^^
Grammar mistake, should be 'needs'.
>
> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
The title of this patch is a bit vague, perhaps something like:
"ARM: dma-mapping: Fix the type used for consistent_pte size
calculation"
The actual patch looks correct.
--
Tixy
> ---
> arch/arm/mm/dma-mapping.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 1aa664a..04bfa76 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -170,7 +170,7 @@ static int __init consistent_init(void)
> unsigned long base = consistent_base;
> unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>
> - consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
> + consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
> if (!consistent_pte) {
> pr_err("%s: no memory\n", __func__);
> return -ENOMEM;
next prev parent reply other threads:[~2012-02-18 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 13:09 [PATCH 1/2] ARM: dma-mapping: its array of pointer Ajeet Yadav
2012-02-18 15:48 ` Tixy [this message]
2012-02-22 3:36 ` Ajeet Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329580086.2448.12.camel@computer2.home \
--to=tixy@yxit.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).