From mboxrd@z Thu Jan 1 00:00:00 1970 From: tixy@yxit.co.uk (Tixy) Date: Sat, 18 Feb 2012 15:48:06 +0000 Subject: [PATCH 1/2] ARM: dma-mapping: its array of pointer In-Reply-To: <1329484170-26329-1-git-send-email-ajeet.yadav.77@gmail.com> References: <1329484170-26329-1-git-send-email-ajeet.yadav.77@gmail.com> Message-ID: <1329580086.2448.12.camel@computer2.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2012-02-17 at 18:39 +0530, Ajeet Yadav wrote: > To be consistant with declaration and usage of ^^^^^^^^^^ Spelling mistake, should be 'consistent' > consistent_pte it need to be an array of (pte *) ^^^^ Grammar mistake, should be 'needs'. > > Signed-off-by: Ajeet Yadav The title of this patch is a bit vague, perhaps something like: "ARM: dma-mapping: Fix the type used for consistent_pte size calculation" The actual patch looks correct. -- Tixy > --- > arch/arm/mm/dma-mapping.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index 1aa664a..04bfa76 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -170,7 +170,7 @@ static int __init consistent_init(void) > unsigned long base = consistent_base; > unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT; > > - consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL); > + consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL); > if (!consistent_pte) { > pr_err("%s: no memory\n", __func__); > return -ENOMEM;