From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1388AC43461 for ; Thu, 17 Sep 2020 10:31:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9044F2083B for ; Thu, 17 Sep 2020 10:31:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LG4a7lmN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9044F2083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rR8tIq6LJJyi+wS6svwgkrr10lYY0SszFnRHhyO/kAk=; b=LG4a7lmNUpLsrtG8aFXabeA4T PMxDmTApWZLmEpsSGomCe5Uw5zw5TFgmdX/88H2qf8gRNCR+ip3MgWmFVPKNx/JV8/Saewp3FCyu1 DOKMHfNPKuIOGbwdL2ctpUxuzk+fw0nd8fpwYa97aewPNCOVl5/hA8SfNYp9TRjlbtWlx+uj4brMA oZmdS0/Ncfdrw5jbZKSYgCkilImgBfqFKWx41/a+wVesQ3ssHYhdqCjISc/LLLp4WdZHwMw8h152W usybNI196vIFNJLtBQQAoIFCWC3ciT7CG+caiydjMZ9Wl60NnP2NJPazkZCDAmwakEOTyYRKccJdC ZnXYLXrZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIrAd-0006dQ-7T; Thu, 17 Sep 2020 10:29:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIrA9-0006SY-6S; Thu, 17 Sep 2020 10:29:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2A4F1424; Thu, 17 Sep 2020 03:29:12 -0700 (PDT) Received: from [192.168.1.79] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C96423F68F; Thu, 17 Sep 2020 03:29:10 -0700 (PDT) Subject: Re: [PATCH v2 3/3] drm/panfrost: add Amlogic GPU integration quirks To: Neil Armstrong , robh@kernel.org, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com References: <20200916150147.25753-1-narmstrong@baylibre.com> <20200916150147.25753-4-narmstrong@baylibre.com> From: Steven Price Message-ID: <132c32b9-b68a-8da9-310e-c85fe17be83e@arm.com> Date: Thu, 17 Sep 2020 11:29:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200916150147.25753-4-narmstrong@baylibre.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_062913_360335_2CFBA6F0 X-CRM114-Status: GOOD ( 19.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/09/2020 16:01, Neil Armstrong wrote: > This adds the required GPU quirks, including the quirk in the PWR registers at the GPU > reset time and the IOMMU quirk for shareability issues observed on G52 in Amlogic G12B SoCs. > > Signed-off-by: Neil Armstrong Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 7c8a87d164c3..6e5dedacb777 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -658,7 +658,18 @@ static const struct panfrost_compatible default_data = { > .pm_domain_names = NULL, > }; > > +static const struct panfrost_compatible amlogic_data = { > + .num_supplies = ARRAY_SIZE(default_supplies), > + .supply_names = default_supplies, > + .vendor_quirk = panfrost_gpu_amlogic_quirk, > +}; > + > static const struct of_device_id dt_match[] = { > + /* Set first to probe before the generic compatibles */ > + { .compatible = "amlogic,meson-gxm-mali", > + .data = &amlogic_data, }, > + { .compatible = "amlogic,meson-g12a-mali", > + .data = &amlogic_data, }, > { .compatible = "arm,mali-t604", .data = &default_data, }, > { .compatible = "arm,mali-t624", .data = &default_data, }, > { .compatible = "arm,mali-t628", .data = &default_data, }, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel