From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators
Date: Fri, 24 Feb 2012 17:04:44 +0200 [thread overview]
Message-ID: <1330095884.4102.564.camel@sokoban> (raw)
In-Reply-To: <20120224145027.GN5450@opensource.wolfsonmicro.com>
On Fri, 2012-02-24 at 14:50 +0000, Mark Brown wrote:
> On Fri, Feb 24, 2012 at 04:42:12PM +0200, Tero Kristo wrote:
> > On Fri, 2012-02-24 at 14:34 +0000, Mark Brown wrote:
>
> > > Ah, so it is - we're fixing things up in the core. I'd forgotten we did
> > > that.
>
> > So, no need to add list_voltage to this, I just fix the return values
> > for the get / set and send the new version, am I right?
>
> I guess. Though actually given that there's no interaction with the
> chip itself at all I'm not sure I understand why this is part of the
> twl6030 driver rather than being a separate driver for whatever
> implements the operations - it's not like the case with the other
> regulators where there was some functionality implemented through the
> twl6030 driver beyond straight passthrough.
Well, there are still some registers within twl6030 that could be
accessed through the control channel, it is just that the voltage
registers are no longer visible through this. We have the CFG_GRP,
CFG_TRANS, CFG_STATE and CFG_STEP registers visible here, even though we
are not accessing them right now.
-Tero
prev parent reply other threads:[~2012-02-24 15:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 11:05 [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators Tero Kristo
2012-02-23 15:34 ` Mark Brown
2012-02-24 9:38 ` Tero Kristo
2012-02-24 11:49 ` Mark Brown
2012-02-24 13:16 ` Tero Kristo
2012-02-24 13:24 ` Mark Brown
2012-02-24 13:56 ` Tero Kristo
2012-02-24 14:01 ` Mark Brown
2012-02-24 14:25 ` Tero Kristo
2012-02-24 14:34 ` Mark Brown
2012-02-24 14:42 ` Tero Kristo
2012-02-24 14:50 ` Mark Brown
2012-02-24 15:04 ` Tero Kristo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330095884.4102.564.camel@sokoban \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox